Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2407f699e935
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c1e207d6acb2
Choose a head ref
  • 19 commits
  • 655 files changed
  • 7 contributors

Commits on Dec 15, 2023

  1. Roll Flutter Engine from 986a6fe198dc to e89b7ed8812b (1 revision) (#…

    …140224)
    
    flutter/engine@986a6fe...e89b7ed
    
    2023-12-15 skia-flutter-autoroll@skia.org Roll Skia from 1537198c5461 to 0e0e00e2969b (1 revision) (flutter/engine#49088)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Dec 15, 2023
    Configuration menu
    Copy the full SHA
    b211133 View commit details
    Browse the repository at this point in the history
  2. Roll Flutter Engine from e89b7ed8812b to b36374085c4b (1 revision) (#…

    …140228)
    
    flutter/engine@e89b7ed...b363740
    
    2023-12-15 skia-flutter-autoroll@skia.org Roll Skia from 0e0e00e2969b to 7a97b766b14b (1 revision) (flutter/engine#49090)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Dec 15, 2023
    Configuration menu
    Copy the full SHA
    85523f2 View commit details
    Browse the repository at this point in the history
  3. Roll Flutter Engine from b36374085c4b to db98451b063c (1 revision) (#…

    …140230)
    
    flutter/engine@b363740...db98451
    
    2023-12-15 jason-simmons@users.noreply.github.com Revert "[Impeller] Provide the clear color to an advanced blend if it was optimized out" (flutter/engine#49064)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Dec 15, 2023
    Configuration menu
    Copy the full SHA
    253a90f View commit details
    Browse the repository at this point in the history
  4. [macOS,iOS] CocoaPods recommended version: 1.13.0 (#135447)

    Due to changes in Xcode 15, several variables such as `DT_TOOLCHAIN_DIR`
    have been eliminateed in favour of others such as `TOOLCHAIN_DIR`. This
    broke CocoaPods support under Xcode 15, as reported in:
    CocoaPods/CocoaPods#12012
    
    @vashworth worked around this in Flutter in:
    #132803
    
    The CocoaPods issue was resolved by the following PR to their repo:
    CocoaPods/CocoaPods#12009
    and was released in CocoaPods 1.13.0.
    
    Also switches from an if-else chain to a switch for CocoaPodsStatus
    handling.
    
    Related: #133584
    Related: #132755
    
    ## Pre-launch Checklist
    
    - [X] I read the [Contributor Guide] and followed the process outlined
    there for submitting PRs.
    - [X] I read the [Tree Hygiene] wiki page, which explains my
    responsibilities.
    - [X] I read and followed the [Flutter Style Guide], including [Features
    we expect every widget to implement].
    - [X] I signed the [CLA].
    - [X] I listed at least one issue that this PR fixes in the description
    above.
    - [X] I updated/added relevant documentation (doc comments with `///`).
    - [X] I added new tests to check the change I am making, or this PR is
    [test-exempt].
    - [X] All existing and new tests are passing.
    
    If you need help, consider asking for advice on the #hackers-new channel
    on [Discord].
    
    <!-- Links -->
    [Contributor Guide]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
    [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
    [test-exempt]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
    [Flutter Style Guide]:
    https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
    [Features we expect every widget to implement]:
    https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
    [CLA]: https://cla.developers.google.com/
    [flutter/tests]: https://github.com/flutter/tests
    [breaking change policy]:
    https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
    [Discord]: https://github.com/flutter/flutter/wiki/Chat
    
    Co-authored-by: Greg Spencer <gspencergoog@users.noreply.github.com>
    cbracken and gspencergoog authored Dec 15, 2023
    Configuration menu
    Copy the full SHA
    d0670f0 View commit details
    Browse the repository at this point in the history
  5. Reorganize dependencies on leak_tracker. (#140233)

    1. Move leak_tracker and leak_tracker_testing out of direct dependencies.
    2. Move leak_tracker_flutter_testing from dev to prod dependencies for flutter_test
    
    It is prerequisite for #135856
    polina-c authored Dec 15, 2023
    Configuration menu
    Copy the full SHA
    bda158a View commit details
    Browse the repository at this point in the history
  6. Roll Flutter Engine from db98451b063c to c48b08ac4682 (2 revisions) (#…

    …140236)
    
    flutter/engine@db98451...c48b08a
    
    2023-12-15 skia-flutter-autoroll@skia.org Roll Skia from c10028c9756f to 4f0f3f3992e0 (2 revisions) (flutter/engine#49094)
    2023-12-15 skia-flutter-autoroll@skia.org Roll Skia from 7a97b766b14b to c10028c9756f (1 revision) (flutter/engine#49091)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Dec 15, 2023
    Configuration menu
    Copy the full SHA
    c35c42a View commit details
    Browse the repository at this point in the history
  7. Use new enabledFeature param for Analytics (#139934)

    Related to tracker issue:
    - #128251
    
    This updates the `Analytics` constructor to provide it with the enabled features for the flutter-tool. This will be sent with each event for the flutter-tool.
    eliasyishak authored Dec 15, 2023
    Configuration menu
    Copy the full SHA
    d180c12 View commit details
    Browse the repository at this point in the history
  8. Roll Flutter Engine from c48b08ac4682 to a8d861b53db1 (1 revision) (#…

    …140240)
    
    flutter/engine@c48b08a...a8d861b
    
    2023-12-15 skia-flutter-autoroll@skia.org Roll Skia from 4f0f3f3992e0 to cf84bab13da3 (1 revision) (flutter/engine#49097)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Dec 15, 2023
    Configuration menu
    Copy the full SHA
    d57e7ac View commit details
    Browse the repository at this point in the history
  9. Roll Flutter Engine from a8d861b53db1 to 6e3a04874be5 (1 revision) (#…

    …140244)
    
    flutter/engine@a8d861b...6e3a048
    
    2023-12-15 15619084+vashworth@users.noreply.github.com Run tests on macOS 13 exclusively (flutter/engine#49099)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Dec 15, 2023
    Configuration menu
    Copy the full SHA
    7014588 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    baf739c View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2023

  1. Roll Flutter Engine from 6e3a04874be5 to ca329dd84207 (3 revisions) (#…

    …140255)
    
    flutter/engine@6e3a048...ca329dd
    
    2023-12-15 bdero@google.com [Impeller] Turn off Aiks bounds tracking for filtered SaveLayers. (flutter/engine#49076)
    2023-12-15 skia-flutter-autoroll@skia.org Roll Skia from cf84bab13da3 to 191943f9c43e (1 revision) (flutter/engine#49105)
    2023-12-15 skia-flutter-autoroll@skia.org Roll Dart SDK from e6528d1b7997 to d66f9c854db7 (1 revision) (flutter/engine#49104)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Dec 16, 2023
    Configuration menu
    Copy the full SHA
    388ba45 View commit details
    Browse the repository at this point in the history
  2. [github actions] minor PR to test latest github actions (#140252)

    Minor fix of a typo.
    
    A merged PR on flutter/flutter with a newer base commit is needed to test the latest version of https://github.com/flutter/flutter/blob/master/.github/workflows/easy-cp.yml. (more details in #140191 (comment)).
    
    This PR has a base commit that includes the latest updates to easy-cp.yml, and would be a good candidate for testing purposes when merged
    XilaiZhang authored Dec 16, 2023
    Configuration menu
    Copy the full SHA
    c176221 View commit details
    Browse the repository at this point in the history
  3. Roll Flutter Engine from ca329dd84207 to 74e4965a2845 (4 revisions) (#…

    …140262)
    
    flutter/engine@ca329dd...74e4965
    
    2023-12-16 dnfield@google.com Statically link swiftshader into flutter_tester (flutter/engine#48708)
    2023-12-16 jason-simmons@users.noreply.github.com [Impeller] Do not pass the depfile flag when creating a shader bundle in ImpellerC (flutter/engine#49114)
    2023-12-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Run tests on macOS 13 exclusively" (flutter/engine#49115)
    2023-12-15 dnfield@google.com Roll SwiftShader to 2fa7e9b99ae4e70ea5ae2cc9c8d3afb43391384f (flutter/engine#49112)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Dec 16, 2023
    Configuration menu
    Copy the full SHA
    445bd51 View commit details
    Browse the repository at this point in the history
  4. Roll Flutter Engine from 74e4965a2845 to 34d427aa009c (1 revision) (#…

    …140263)
    
    flutter/engine@74e4965...34d427a
    
    2023-12-16 skia-flutter-autoroll@skia.org Roll Dart SDK from d66f9c854db7 to 620976ef6b80 (2 revisions) (flutter/engine#49125)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Dec 16, 2023
    Configuration menu
    Copy the full SHA
    42eebee View commit details
    Browse the repository at this point in the history
  5. Roll Flutter Engine from 34d427aa009c to 832238a3b493 (1 revision) (#…

    …140265)
    
    flutter/engine@34d427a...832238a
    
    2023-12-16 skia-flutter-autoroll@skia.org Roll Skia from 191943f9c43e to 01aa69c38af5 (4 revisions) (flutter/engine#49128)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Dec 16, 2023
    Configuration menu
    Copy the full SHA
    8b4ece2 View commit details
    Browse the repository at this point in the history
  6. Roll Flutter Engine from 832238a3b493 to 7d300e5b9587 (1 revision) (#…

    …140268)
    
    flutter/engine@832238a...7d300e5
    
    2023-12-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 620976ef6b80 to c8106261c9cd (1 revision) (flutter/engine#49131)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Dec 16, 2023
    Configuration menu
    Copy the full SHA
    0c6850d View commit details
    Browse the repository at this point in the history
  7. Roll Flutter Engine from 7d300e5b9587 to 6752398c2f54 (1 revision) (#…

    …140270)
    
    flutter/engine@7d300e5...6752398
    
    2023-12-16 skia-flutter-autoroll@skia.org Roll Skia from 01aa69c38af5 to d231faf34f8a (1 revision) (flutter/engine#49134)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Dec 16, 2023
    Configuration menu
    Copy the full SHA
    3958b3d View commit details
    Browse the repository at this point in the history
  8. Use SemanticsUpdateBuilder again, remove all references to temporar…

    …y `SemanticsUpdateBuilderNew` (#139942)
    
    This PR removes all usages of the temporary `SemanticsUpdateBuilderNew` API in favor of `SemanticsUpdateBuilder`. These two APIs are the same as of now.
    
    This is mainly targeted at #17988
    
    Steps:
    part 1: [engine] add `SemanticsUpdateBuilderNew` flutter/engine#47961
    part 2: [flutter] use `SemanticsUpdateBuilderNew` #138331
    part 3: [engine] update `SemanticsUpdateBuilder` to be the same as `SemanticsUpdateBuilderNew` flutter/engine#48882
    **part 4: [flutter] use (now updated) `SemanticsUpdateBuilder` again** <-- we are here
    part 5: [engine] remove `SemanticsBuilderNew`
    bartekpacia authored Dec 16, 2023
    Configuration menu
    Copy the full SHA
    8c02a22 View commit details
    Browse the repository at this point in the history
  9. Roll Flutter Engine from 6752398c2f54 to a8d8fbbcef22 (1 revision) (#…

    …140274)
    
    flutter/engine@6752398...a8d8fbb
    
    2023-12-16 skia-flutter-autoroll@skia.org Roll Skia from d231faf34f8a to 35d0d7eb991c (1 revision) (flutter/engine#49137)
    
    If this roll has caused a breakage, revert this CL and stop the roller
    using the controls here:
    https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
    Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
    is aware of the problem.
    
    To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
    
    To report a problem with the AutoRoller itself, please file a bug:
    https://issues.skia.org/issues/new?component=1389291&template=1850622
    
    Documentation for the AutoRoller is here:
    https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
    engine-flutter-autoroll authored Dec 16, 2023
    Configuration menu
    Copy the full SHA
    c1e207d View commit details
    Browse the repository at this point in the history
Loading