Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix flutter/flutter #34791 #9977

Merged
merged 3 commits into from
Aug 15, 2019
Merged

Fix flutter/flutter #34791 #9977

merged 3 commits into from
Aug 15, 2019

Conversation

inthroxify
Copy link
Contributor

This is a fix for flutter/flutter issue #34791.

PR #8048 in flutter/engine produced a bug/regression (flutter/flutter #34791) in flutter for Android that doesn't permit the Recents app bar color to be changed. This restores the original arguments to the function found in the previous version (https://github.com/flutter/engine/blob/2f4a38dbd33061e950cf83ddc31785803d58c126/shell/platform/android/io/flutter/plugin/platform/PlatformPlugin.java) of PlatformPlugin.java while preserving the enhancements for the linter.

I've compiled and tested this fix locally. The bar changes color again.

PR flutter#8048 in flutter/engine produced a bug (flutter/flutter flutter#34791) in flutter for Android that doesn't permit the Recents app bar color to be changed. This restores the original arguments to the function found in the previous version (https://github.com/flutter/engine/blob/2f4a38dbd33061e950cf83ddc31785803d58c126/shell/platform/android/io/flutter/plugin/platform/PlatformPlugin.java) of PlatformPlugin.java while preserving the enhancements for the linter.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@inthroxify
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

Edited to add: The test failure looks unrelated and has been fixed in a newer version of the engine, should be fixed if you merge in the latest changes.

inthroxify and others added 2 commits August 14, 2019 20:25
…in.java


Annotate the icon parameter for anybody reading the code who doesn't know the whole method signature.

Co-Authored-By: Michael Klimushyn <mklim@google.com>
@mklim mklim merged commit 2e8e693 into flutter:master Aug 15, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 15, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 15, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 16, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Aug 16, 2019
git@github.com:flutter/engine.git/compare/f8e7453f1106...4b7a552

git log f8e7453..4b7a552 --no-merges --oneline
2019-08-16 stuartmorgan@google.com Roll Dart back to e35e8833 (flutter/engine#11043)
2019-08-16 bkonyi@google.com Roll src/third_party/dart 306f8e04bb..fecc4c8f2d (4 commits)
2019-08-16 skia-flutter-autoroll@skia.org Roll src/third_party/skia 963a606677e1..6a519b8dd895 (6 commits) (flutter/engine#11042)
2019-08-15 liyuqian@google.com Hide verbose dart snapshot during run_test.py (flutter/engine#11040)
2019-08-15 chinmaygarde@google.com Remove ability to override mac_sdk_path in flutter/tools/gn (flutter/engine#11013)
2019-08-15 bkonyi@google.com Roll src/third_party/dart cd16fba718..306f8e04bb (10 commits)
2019-08-15 stuartmorgan@google.com Roll buildroot to pick up recent macOS changes (flutter/engine#11037)
2019-08-15 jason-simmons@users.noreply.github.com Remove the ParagraphImpl class from the text API (flutter/engine#11012)
2019-08-15 jason-simmons@users.noreply.github.com Disable a deprecation warning for use of a TaskDescription constructor for older platforms (flutter/engine#11029)
2019-08-15 matthew-carroll@users.noreply.github.com Re-lands platform brightness support on iOS, plus platform contrast (flutter/engine#10791)
2019-08-15 iska.kaushik@gmail.com [fuchsia] Add required trace so files for fuchsia fars (flutter/engine#11036)
2019-08-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia e5dc1ebc864a..963a606677e1 (14 commits) (flutter/engine#11032)
2019-08-15 stuartmorgan@google.com Add _glfw versions of the GLFW desktop libraries (flutter/engine#11024)
2019-08-15 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from _fvZN... to 5Nhwb... (flutter/engine#11028)
2019-08-15 bkonyi@google.com Roll src/third_party/dart 9552646dc4..cd16fba718 (5 commits)
2019-08-15 dnfield@google.com Fix first frame logic (flutter/engine#11027)
2019-08-15 dnfield@google.com remove OS version (flutter/engine#11033)
2019-08-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia e30a485a68c9..e5dc1ebc864a (7 commits) (flutter/engine#11025)
2019-08-15 bkonyi@google.com Roll src/third_party/dart cae08c6813..9552646dc4 (3 commits)
2019-08-15 jason-simmons@users.noreply.github.com Remove the output directory prefix from the Android engine JAR filename (flutter/engine#11015)
2019-08-15 inthroxify@users.noreply.github.com Fix flutter/flutter #34791 (flutter/engine#9977)
2019-08-15 bkonyi@google.com Roll src/third_party/dart e35e8833ee..cae08c6813 (28 commits)
2019-08-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia f3f50099533d..e30a485a68c9 (2 commits) (flutter/engine#11022)
2019-08-15 skia-flutter-autoroll@skia.org Roll src/third_party/skia 319fd3d7bcb4..f3f50099533d (4 commits) (flutter/engine#11021)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (stuartmorgan@google.com), and stop
the roller if necessary.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants