This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix header include guards for fml/thread_local.h #8721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on flutter#8659, I had planned on renaming this file to thread_local_unique_ptr.h, but decided against that at the last minute before sending for review. However, when reverting the file rename, I forgot to also revert the header guard change.
|
/cc @chinmaygarde |
chinmaygarde
approved these changes
Apr 24, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 29, 2019
This was referenced Apr 29, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 30, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 30, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 30, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 30, 2019
flutter/engine@1ecf924...c003631 git log 1ecf924..c003631 --no-merges --oneline c003631 Roll src/third_party/skia bd425405f3aa..79e53712a05f (3 commits) (flutter/engine#8783) 5aa5b6c VirtualDisplay size constraint - add a comment explaining the reason (flutter/engine#8780) ee3f04a Roll src/third_party/skia 037884e5080b..bd425405f3aa (3 commits) (flutter/engine#8781) ab01d73 Roll src/third_party/skia d425dee662d1..037884e5080b (10 commits) (flutter/engine#8778) a0bb23a Fix header include guards for fml/thread_local.h (flutter/engine#8721) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #8659, I had planned on renaming this file to
thread_local_unique_ptr.h, but decided against that at the last minute
before sending for review. However, when reverting the file rename, I
forgot to also revert the header guard change.