This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add api 21 check to LocalizationChannel.java #7967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Feb 26, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 26, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 26, 2019
|
Can we add a test to make sure we don't regress this? (Or ideally, a test so that we catch this entire class of bugs going forward?) |
|
I think we can probably "test" this by creating a few example apps that target different APIs. @dnfield do you think we could work together tomorrow to try to do that? I also need to do something like that to prove out the direction of the embedding anyway.... |
|
@cbracken mentioned he filed an issue to add a device lab test that uses an API 16 android device to ensure we are still functional on the earliest API we support. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 27, 2019
|
Let's sit together tomorrow at some point on this stuff. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 27, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 27, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 27, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 27, 2019
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
Feb 27, 2019
flutter/engine@4434a39c7 Add api 21 check to LocalizationChannel.java (flutter/engine#7967)
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
Feb 28, 2019
flutter/engine@3e4e6f5c5 Provide batching for semantics updates (flutter/engine#7988) flutter/engine@0852795bf Roll src/third_party/skia ff84d8a900d4..67d87128fd00 (7 commits) (flutter/engine#7987) flutter/engine@1089b5c9f Check for a null pressure range for motion events (flutter/engine#7986) flutter/engine@b7d512949 [macos] Add hover support to FLEViewController (flutter/engine#7975) flutter/engine@a82c7ee73 Add async events to pipeline flows. (flutter/engine#7985) flutter/engine@c3eb7aea8 Roll src/third_party/skia ab3f8674c9d2..ff84d8a900d4 (1 commits) (flutter/engine#7983) flutter/engine@15793288e Roll src/third_party/dart 9450c6d829..40bab34fbd (8 commits) flutter/engine@b324969c1 Roll src/third_party/dart e94e797d7b..9450c6d829 (8 commits) flutter/engine@3f3e4ec90 Roll src/third_party/skia f6faf2fcea7b..ab3f8674c9d2 (2 commits) (flutter/engine#7980) flutter/engine@d162ad842 Roll src/third_party/skia 4dbb96dfaa04..f6faf2fcea7b (7 commits) (flutter/engine#7977) flutter/engine@5deb15cdf Roll src/third_party/dart 05bba46133..e94e797d7b (5 commits) flutter/engine@4db7c3050 Android Embedding PR 10: Add system channels to FlutterEngine. (flutter/engine#7960) flutter/engine@9f92324fd Suppress deprecation warning for usage of Configuration.locale (flutter/engine#7973) flutter/engine@9b21ea857 Roll src/third_party/dart 385be0cf31..05bba46133 (6 commits) flutter/engine@e3f1bdc4d Roll src/third_party/skia adfc6e40df30..4dbb96dfaa04 (6 commits) (flutter/engine#7970) flutter/engine@e32531f0e Switch flutter's dart sdk to full and add dartdevc libraries (flutter/engine#7968) flutter/engine@fb1c543dd Link dart:* sources into engine for debugger source support (flutter/engine#7908) flutter/engine@dd3656a51 Roll src/third_party/dart 0f9a5198bd..385be0cf31 (14 commits) flutter/engine@4434a39c7 Add api 21 check to LocalizationChannel.java (flutter/engine#7967)
cbracken
added a commit
to flutter/flutter
that referenced
this pull request
Feb 28, 2019
flutter/engine@3e4e6f5c5 Provide batching for semantics updates (flutter/engine#7988) flutter/engine@0852795bf Roll src/third_party/skia ff84d8a900d4..67d87128fd00 (7 commits) (flutter/engine#7987) flutter/engine@1089b5c9f Check for a null pressure range for motion events (flutter/engine#7986) flutter/engine@b7d512949 [macos] Add hover support to FLEViewController (flutter/engine#7975) flutter/engine@a82c7ee73 Add async events to pipeline flows. (flutter/engine#7985) flutter/engine@c3eb7aea8 Roll src/third_party/skia ab3f8674c9d2..ff84d8a900d4 (1 commits) (flutter/engine#7983) flutter/engine@15793288e Roll src/third_party/dart 9450c6d829..40bab34fbd (8 commits) flutter/engine@b324969c1 Roll src/third_party/dart e94e797d7b..9450c6d829 (8 commits) flutter/engine@3f3e4ec90 Roll src/third_party/skia f6faf2fcea7b..ab3f8674c9d2 (2 commits) (flutter/engine#7980) flutter/engine@d162ad842 Roll src/third_party/skia 4dbb96dfaa04..f6faf2fcea7b (7 commits) (flutter/engine#7977) flutter/engine@5deb15cdf Roll src/third_party/dart 05bba46133..e94e797d7b (5 commits) flutter/engine@4db7c3050 Android Embedding PR 10: Add system channels to FlutterEngine. (flutter/engine#7960) flutter/engine@9f92324fd Suppress deprecation warning for usage of Configuration.locale (flutter/engine#7973) flutter/engine@9b21ea857 Roll src/third_party/dart 385be0cf31..05bba46133 (6 commits) flutter/engine@e3f1bdc4d Roll src/third_party/skia adfc6e40df30..4dbb96dfaa04 (6 commits) (flutter/engine#7970) flutter/engine@e32531f0e Switch flutter's dart sdk to full and add dartdevc libraries (flutter/engine#7968) flutter/engine@fb1c543dd Link dart:* sources into engine for debugger source support (flutter/engine#7908) flutter/engine@dd3656a51 Roll src/third_party/dart 0f9a5198bd..385be0cf31 (14 commits) flutter/engine@4434a39c7 Add api 21 check to LocalizationChannel.java (flutter/engine#7967)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix forward for flutter/flutter#28495
Missing and API 21 check.