This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Don't call OnAnimatorNotifyIdle if a frame is scheduled #7746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a frame is scheduled by the time the delayed animator notify idle task runs, then we should not call |NotifyIdle|. Also, add a trace event in the task, to make it more clear in traces when a notify idle call is coming from here (as opposed to |Animator::AwaitVSync|).
chinmaygarde
approved these changes
Feb 8, 2019
rmacnak-google
approved these changes
Feb 8, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 9, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Feb 9, 2019
flutter/engine@7c70240...90569e8 git log 7c70240..90569e8 --no-merges --oneline 90569e8 Provide public api to allow FlutterEngine related context to be destoryed (flutter/engine#7610) 693645e Revert "Add mock capability to PerformanceOverlayLayer (#7537)" (flutter/engine#7765) d130f15 Add x bit to some python scripts (flutter/engine#7764) 2146cde Roll src/third_party/skia 706a7cd1e826..87461aad7285 (1 commits) (flutter/engine#7763) 2a648b9 Roll src/third_party/skia be39f713e530..706a7cd1e826 (4 commits) (flutter/engine#7761) 68396ae Throttle picture raster cache (flutter/engine#7759) a6753b0 Roll src/third_party/dart 52f5e34dbf..174d6fec3d (12 commits) f9252e7 allow specifying out directory root (flutter/engine#7753) 12d0b95 Don't call OnAnimatorNotifyIdle if a frame is scheduled (flutter/engine#7746) 5f3f3bd Add mock capability to PerformanceOverlayLayer (flutter/engine#7537) 7d97afd Roll src/third_party/skia 37064c1739f3..be39f713e530 (7 commits) (flutter/engine#7757) 3bfd265 Add flutter config to macOS targets (flutter/engine#7756) 4d3a112 Document GPUSurfaceGLDelegate methods and move it to its own file. (flutter/engine#7755) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop the roller if necessary.
kangwang1988
pushed a commit
to XianyuTech/flutter
that referenced
this pull request
Feb 12, 2019
flutter/engine@7c70240...90569e8 git log 7c70240..90569e8 --no-merges --oneline 90569e8 Provide public api to allow FlutterEngine related context to be destoryed (flutter/engine#7610) 693645e Revert &flutter#34;Add mock capability to PerformanceOverlayLayer (flutter#7537)&flutter#34; (flutter/engine#7765) d130f15 Add x bit to some python scripts (flutter/engine#7764) 2146cde Roll src/third_party/skia 706a7cd1e826..87461aad7285 (1 commits) (flutter/engine#7763) 2a648b9 Roll src/third_party/skia be39f713e530..706a7cd1e826 (4 commits) (flutter/engine#7761) 68396ae Throttle picture raster cache (flutter/engine#7759) a6753b0 Roll src/third_party/dart 52f5e34dbf..174d6fec3d (12 commits) f9252e7 allow specifying out directory root (flutter/engine#7753) 12d0b95 Don&flutter#39;t call OnAnimatorNotifyIdle if a frame is scheduled (flutter/engine#7746) 5f3f3bd Add mock capability to PerformanceOverlayLayer (flutter/engine#7537) 7d97afd Roll src/third_party/skia 37064c1739f3..be39f713e530 (7 commits) (flutter/engine#7757) 3bfd265 Add flutter config to macOS targets (flutter/engine#7756) 4d3a112 Document GPUSurfaceGLDelegate methods and move it to its own file. (flutter/engine#7755) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a frame is scheduled by the time the delayed animator notify idle
task runs, then we should not call |NotifyIdle|.
Also, add a trace event in the task, to make it more clear in traces
when a notify idle call is coming from here (as opposed to
|Animator::AwaitVSync|).