Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Respect default goma path on Windows #7643

Merged
merged 3 commits into from
Jan 30, 2019
Merged

Respect default goma path on Windows #7643

merged 3 commits into from
Jan 30, 2019

Conversation

liyuqian
Copy link
Contributor

No description provided.

@liyuqian liyuqian requested a review from chinmaygarde January 30, 2019 19:34
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

chinmaygarde
chinmaygarde approved these changes Jan 30, 2019
View reviewed changes
tools/gn Outdated

# GOMA_DIR may not be set if goma is installed in the default path on gWindows.
if not os.path.exists(goma_home_dir) and sys.platform.startswith(('cygwin', 'win')):
goma_home_dir = "c:\\src\\goma\\goma-win64"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: os.path.join

@liyuqian liyuqian merged commit 09a3735 into flutter:master Jan 30, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 31, 2019
@engine-flutter-autoroll
09a3735 Respect default goma path on Windows (flutter/engine#7643)
77a1e2c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 31, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 31, 2019
@engine-flutter-autoroll
09a3735 Respect default goma path on Windows (flutter/engine#7643)
e880b9f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 31, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 31, 2019
@engine-flutter-autoroll
09a3735 Respect default goma path on Windows (flutter/engine#7643)
94648de
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 31, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 31, 2019
@engine-flutter-autoroll
09a3735 Respect default goma path on Windows (flutter/engine#7643)
eaa07da
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 31, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 31, 2019
@engine-flutter-autoroll
09a3735 Respect default goma path on Windows (flutter/engine#7643)
2c1c470
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 31, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 31, 2019
@engine-flutter-autoroll
09a3735 Respect default goma path on Windows (flutter/engine#7643)
981ae4a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 31, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 1, 2019
@engine-flutter-autoroll
09a3735 Respect default goma path on Windows (flutter/engine#7643)
c732b6b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 1, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 1, 2019
@engine-flutter-autoroll
09a3735 Respect default goma path on Windows (flutter/engine#7643)
dc9702a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 1, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 1, 2019
@engine-flutter-autoroll
09a3735 Respect default goma path on Windows (flutter/engine#7643)
70e3bd5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 1, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 1, 2019
@engine-flutter-autoroll
09a3735 Respect default goma path on Windows (flutter/engine#7643)
fae7b0e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 1, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 1, 2019
@engine-flutter-autoroll
09a3735 Respect default goma path on Windows (flutter/engine#7643)
eecb339
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 1, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 1, 2019
@engine-flutter-autoroll
09a3735 Respect default goma path on Windows (flutter/engine#7643)
8be8500
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 1, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 1, 2019
@engine-flutter-autoroll
09a3735 Respect default goma path on Windows (flutter/engine#7643)
db1f174
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 1, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 1, 2019
@engine-flutter-autoroll
09a3735 Respect default goma path on Windows (flutter/engine#7643)
0c62d3d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 1, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 2, 2019
@engine-flutter-autoroll
09a3735 Respect default goma path on Windows (flutter/engine#7643)
60293f8
This was referenced Feb 2, 2019
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 2, 2019
@engine-flutter-autoroll
09a3735 Respect default goma path on Windows (flutter/engine#7643)
c2a55fb
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 2, 2019
@engine-flutter-autoroll
09a3735 Respect default goma path on Windows (flutter/engine#7643)
8293a69
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 2, 2019
@engine-flutter-autoroll
09a3735 Respect default goma path on Windows (flutter/engine#7643)
da90b1c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 2, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 3, 2019
@engine-flutter-autoroll
09a3735 Respect default goma path on Windows (flutter/engine#7643)
65a4d4a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 3, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 3, 2019
@engine-flutter-autoroll
09a3735 Respect default goma path on Windows (flutter/engine#7643)
40fb06c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 3, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 4, 2019
@engine-flutter-autoroll
09a3735 Respect default goma path on Windows (flutter/engine#7643)
978c025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 4, 2019
@engine-flutter-autoroll
09a3735 Respect default goma path on Windows (flutter/engine#7643)
9bf7103
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liyuqian @googlebot @chinmaygarde