This repository was archived by the owner on Feb 25, 2025. It is now read-only.
iOS: Apply nullability annotations to FlutterPlatformViewsController #56839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
force-pushed
the
refactor-platformview-objc-maps
branch
from
c16388c to
4d4bf2f
Compare
hellohuanlin
approved these changes
Nov 27, 2024
shell/platform/darwin/ios/framework/Source/FlutterPlatformViewsController.h
Show resolved
Hide resolved
shell/platform/darwin/ios/framework/Source/FlutterPlatformViewsController.h
Show resolved
Hide resolved
Applies non-null by default annotations to FlutterPlatformViewsController with opt-outs where necessary. Updates unit tests to create graphics contexts where requried.
cbracken
force-pushed
the
refactor-platformview-objc-maps
branch
from
4d4bf2f to
028cf7c
Compare
cbracken
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 28, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 28, 2024
…159595) flutter/engine@d7c0bcf...d7be573 2024-11-28 chris@bracken.jp iOS: Apply nullability annotations to FlutterPlatformViewsController (flutter/engine#56839) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…lutter/engine#56839) Applies non-null by default annotations to FlutterPlatformViewsController with opt-outs where necessary. Updates unit tests to create graphics contexts where requried. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies non-null by default annotations to
FlutterPlatformViewsController with opt-outs where necessary. Updates unit tests to create graphics contexts where requried.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.