[iOS] fix tracking of previous platform views. #56461
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
jonahwilliams
added
the
autosubmit
…158405) flutter/engine@b7134d3...54df0b8 2024-11-08 rosscomputerguy@protonmail.com [Linux] Replace deprecated macros in fl_application_test.cc (flutter/engine#56257) 2024-11-08 jonahwilliams@google.com [iOS] fix tracking of previous platform views. (flutter/engine#56461) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
We need to track all previous platform views, even if some component of the hierarchy is missing.
We need to track all previous platform views, even if some component of the hierarchy is missing.
We need to track all previous platform views, even if some component of the hierarchy is missing.