Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Some cleanups enabled by removing support for Dart 1. #5621

Merged
merged 1 commit into from
Sep 7, 2018
Merged

Some cleanups enabled by removing support for Dart 1. #5621

merged 1 commit into from
Sep 7, 2018

Conversation

rmacnak-google
Copy link
Contributor

  • Switch core snapshot to Dart 2 and remove support for loading platform.dill.
  • Remove support for loading script snapshots.
  • Remove settings and fix names to reflect the above.
  • Remove support for loading the service isolate from source.

@rmacnak-google
Copy link
Contributor Author

FYI @cbracken

@jason-simmons
Copy link
Member

LGTM

The commit message should say "removing support for Dart 1"

@a-siva
Copy link
Contributor

a-siva commented Jun 28, 2018

Is this PR still active?

@rmacnak-google
Copy link
Contributor Author

Yes. Chris is working on removing some lingering use of Dart 1 in some host side tool (IIRC) and the engine's unit tests. This can land after that work is done.

@cbracken
Copy link
Member

De-dart-1-ification is pending a fix to get Fuchsia tests working in kernel mode FL-66, which requires a series of fixes to get the frontend server available as part the SDK.

@chinmaygarde chinmaygarde changed the title WIP: Some cleanups enabled by removing support for Dart. WIP: Some cleanups enabled by removing support for Dart 1. Jun 29, 2018
@chinmaygarde
Copy link
Member

Can we land/close this? Just clearing the queue.

@cbracken
Copy link
Member

cbracken commented Aug 14, 2018 •
edited
Loading

As of this morning, all the blockers for my re-land of de-dart-1-ification are cleared. I've got a flutter_tools PR to land first, then will rebase and re-land that PR, at which point this will be good to go.

@rmacnak-google
Copy link
Contributor Author

Waiting on removal of use of Dart 1 by engine unit tests.

@chinmaygarde
Copy link
Member

Waiting on removal of use of Dart 1 by engine unit tests.

Oh wait. I added these. @cbracken: Is this the only remaining blocker? I can work on migrating the unit tests.

@rmacnak-google rmacnak-google changed the title WIP: Some cleanups enabled by removing support for Dart 1. Some cleanups enabled by removing support for Dart 1. Sep 4, 2018
@rmacnak-google
Copy link
Contributor Author

Ping. PTAL.

@rmacnak-google
Some cleanups enabled by removing support for Dart.
2f3ce16 
 - Switch core snapshot to Dart 2 and remove support for loading platform.dill.
 - Remove support for loading script snapshots.
 - Remove support for loading source.
 - Remove settings and fix names to reflect the above.
 - Remove support for loading the service isolate from source.
@cbracken
Copy link
Member

cbracken commented Sep 7, 2018

lgtm

@rmacnak-google rmacnak-google merged commit 4c2448d into flutter:master Sep 7, 2018
@rmacnak-google rmacnak-google deleted the cleanup branch September 7, 2018 22:48
@cbracken
Copy link
Member

cbracken commented Sep 7, 2018

This is the final nail in the coffin of flutter/flutter#17051.

@cbracken cbracken mentioned this pull request Sep 7, 2018
Closed
rmacnak-google added a commit that referenced this pull request Sep 8, 2018
@rmacnak-google
Revert "Some cleanups enabled by removing support for Dart. (#5621)" (#…
bf96dbe 
…6205)

This reverts commit 4c2448d.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2018
@engine-flutter-autoroll
Roll engine 58a1894..bf96dbe (15 commits)
1b44706 
flutter/engine@58a1894...bf96dbe

git log 58a1894..bf96dbe --no-merges --oneline
bf96dbe Revert "Some cleanups enabled by removing support for Dart. (flutter#5621)" (flutter/engine#6205)
3358115 Roll src/third_party/skia 094b3eaf479c..2810c856dfa2 (6 commits) (flutter/engine#6203)
4c2448d Some cleanups enabled by removing support for Dart. (flutter/engine#5621)
e27a2e9 Dart SDK roll for 2018/09/07 (flutter/engine#6201)
93dac2a Always save canvas and correctly pass antialias boolean in ClipRects. (flutter/engine#6199)
16c56af Roll src/third_party/skia 300b6197e344..094b3eaf479c (17 commits) (flutter/engine#6200)
2af72eb Don't map iOS reduce motion to disabled animations (flutter/engine#6194)
687cf08 Add option to invert paint colors to be used for smart invert accessibility on iOS (flutter/engine#6176)
85d47fb Accept file URIs as parameters in the RunInView service RPC (flutter/engine#6191)
5a19d76 Roll src/third_party/skia 0b80e62a14ae..300b6197e344 (9 commits) (flutter/engine#6198)
f33615c Roll src/third_party/skia b090b2b26803..0b80e62a14ae (2 commits) (flutter/engine#6197)
75f6bdf Revert "Dart SDK roll for 2018/09/06 (flutter#6189)" (flutter/engine#6192)
b09563b Roll src/third_party/skia 106d04e907c1..b090b2b26803 (1 commits) (flutter/engine#6193)
e164e83 Reset the raster cache when the compositor context is created. (flutter/engine#6150)
f02fc8c Dart SDK roll for 2018/09/06 (flutter/engine#6189)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2018
@engine-flutter-autoroll
Roll engine 58a1894..b952331 (16 commits)
850148a 
flutter/engine@58a1894...b952331

git log 58a1894..b952331 --no-merges --oneline
b952331 Allow embedders to specify a custom GL proc address resolver. (flutter/engine#6204)
bf96dbe Revert "Some cleanups enabled by removing support for Dart. (flutter#5621)" (flutter/engine#6205)
3358115 Roll src/third_party/skia 094b3eaf479c..2810c856dfa2 (6 commits) (flutter/engine#6203)
4c2448d Some cleanups enabled by removing support for Dart. (flutter/engine#5621)
e27a2e9 Dart SDK roll for 2018/09/07 (flutter/engine#6201)
93dac2a Always save canvas and correctly pass antialias boolean in ClipRects. (flutter/engine#6199)
16c56af Roll src/third_party/skia 300b6197e344..094b3eaf479c (17 commits) (flutter/engine#6200)
2af72eb Don't map iOS reduce motion to disabled animations (flutter/engine#6194)
687cf08 Add option to invert paint colors to be used for smart invert accessibility on iOS (flutter/engine#6176)
85d47fb Accept file URIs as parameters in the RunInView service RPC (flutter/engine#6191)
5a19d76 Roll src/third_party/skia 0b80e62a14ae..300b6197e344 (9 commits) (flutter/engine#6198)
f33615c Roll src/third_party/skia b090b2b26803..0b80e62a14ae (2 commits) (flutter/engine#6197)
75f6bdf Revert "Dart SDK roll for 2018/09/06 (flutter#6189)" (flutter/engine#6192)
b09563b Roll src/third_party/skia 106d04e907c1..b090b2b26803 (1 commits) (flutter/engine#6193)
e164e83 Reset the raster cache when the compositor context is created. (flutter/engine#6150)
f02fc8c Dart SDK roll for 2018/09/06 (flutter/engine#6189)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 8, 2018
@engine-flutter-autoroll
Roll engine 58a1894..bf3c224 (17 commits)
197cb56 
flutter/engine@58a1894...bf3c224

git log 58a1894..bf3c224 --no-merges --oneline
bf3c224 Roll src/third_party/skia 2810c856dfa2..a3dc329d1db1 (1 commits) (flutter/engine#6206)
b952331 Allow embedders to specify a custom GL proc address resolver. (flutter/engine#6204)
bf96dbe Revert "Some cleanups enabled by removing support for Dart. (flutter#5621)" (flutter/engine#6205)
3358115 Roll src/third_party/skia 094b3eaf479c..2810c856dfa2 (6 commits) (flutter/engine#6203)
4c2448d Some cleanups enabled by removing support for Dart. (flutter/engine#5621)
e27a2e9 Dart SDK roll for 2018/09/07 (flutter/engine#6201)
93dac2a Always save canvas and correctly pass antialias boolean in ClipRects. (flutter/engine#6199)
16c56af Roll src/third_party/skia 300b6197e344..094b3eaf479c (17 commits) (flutter/engine#6200)
2af72eb Don't map iOS reduce motion to disabled animations (flutter/engine#6194)
687cf08 Add option to invert paint colors to be used for smart invert accessibility on iOS (flutter/engine#6176)
85d47fb Accept file URIs as parameters in the RunInView service RPC (flutter/engine#6191)
5a19d76 Roll src/third_party/skia 0b80e62a14ae..300b6197e344 (9 commits) (flutter/engine#6198)
f33615c Roll src/third_party/skia b090b2b26803..0b80e62a14ae (2 commits) (flutter/engine#6197)
75f6bdf Revert "Dart SDK roll for 2018/09/06 (flutter#6189)" (flutter/engine#6192)
b09563b Roll src/third_party/skia 106d04e907c1..b090b2b26803 (1 commits) (flutter/engine#6193)
e164e83 Reset the raster cache when the compositor context is created. (flutter/engine#6150)
f02fc8c Dart SDK roll for 2018/09/06 (flutter/engine#6189)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 8, 2018
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 9, 2018
@engine-flutter-autoroll
Roll engine e27a2e9..5c1a826 (6 commits)
f141f7c 
flutter/engine@e27a2e9...5c1a826

git log e27a2e9..5c1a826 --no-merges --oneline
5c1a826 Roll src/third_party/skia a3dc329d1db1..40c7c64572bc (1 commits) (flutter/engine#6208)
bf3c224 Roll src/third_party/skia 2810c856dfa2..a3dc329d1db1 (1 commits) (flutter/engine#6206)
b952331 Allow embedders to specify a custom GL proc address resolver. (flutter/engine#6204)
bf96dbe Revert "Some cleanups enabled by removing support for Dart. (flutter#5621)" (flutter/engine#6205)
3358115 Roll src/third_party/skia 094b3eaf479c..2810c856dfa2 (6 commits) (flutter/engine#6203)
4c2448d Some cleanups enabled by removing support for Dart. (flutter/engine#5621)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 9, 2018
Merged
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Sep 9, 2018
@engine-flutter-autoroll
Roll engine e27a2e9..5c1a826 (6 commits) (#21608)
bb7735e 
flutter/engine@e27a2e9...5c1a826

git log e27a2e9..5c1a826 --no-merges --oneline
5c1a826 Roll src/third_party/skia a3dc329d1db1..40c7c64572bc (1 commits) (flutter/engine#6208)
bf3c224 Roll src/third_party/skia 2810c856dfa2..a3dc329d1db1 (1 commits) (flutter/engine#6206)
b952331 Allow embedders to specify a custom GL proc address resolver. (flutter/engine#6204)
bf96dbe Revert "Some cleanups enabled by removing support for Dart. (#5621)" (flutter/engine#6205)
3358115 Roll src/third_party/skia 094b3eaf479c..2810c856dfa2 (6 commits) (flutter/engine#6203)
4c2448d Some cleanups enabled by removing support for Dart. (flutter/engine#5621)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
amirh pushed a commit to amirh/engine that referenced this pull request Sep 21, 2018
@rmacnak-google @amirh
Some cleanups enabled by removing support for Dart. (flutter#5621)
f7e2d63 
 - Switch core snapshot to Dart 2 and remove support for loading platform.dill.
 - Remove support for loading script snapshots.
 - Remove support for loading source.
 - Remove settings and fix names to reflect the above.
 - Remove support for loading the service isolate from source.
amirh pushed a commit to amirh/engine that referenced this pull request Sep 21, 2018
@rmacnak-google @amirh
Revert "Some cleanups enabled by removing support for Dart. (flutter#…
ee040de 
…5621)" (flutter#6205)

This reverts commit 4c2448d.
amirh pushed a commit to amirh/engine that referenced this pull request Sep 21, 2018
@rmacnak-google
Some cleanups enabled by removing support for Dart. (flutter#5621)
3e68e5d 
 - Switch core snapshot to Dart 2 and remove support for loading platform.dill.
 - Remove support for loading script snapshots.
 - Remove support for loading source.
 - Remove settings and fix names to reflect the above.
 - Remove support for loading the service isolate from source.
amirh pushed a commit to amirh/engine that referenced this pull request Sep 21, 2018
@rmacnak-google
Revert "Some cleanups enabled by removing support for Dart. (flutter#…
56d413e 
…5621)" (flutter#6205)

This reverts commit 4c2448d.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

1 more reviewer

@cbracken cbracken cbracken approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rmacnak-google @jason-simmons @a-siva @cbracken @chinmaygarde @googlebot