This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] disable AHBs on devices that were upgraded to 29. #56202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtmcdole
approved these changes
Oct 29, 2024
chinmaygarde
approved these changes
Oct 29, 2024
jonahwilliams
added
the
autosubmit
jonahwilliams
added a commit
to jonahwilliams/engine
that referenced
this pull request
Oct 29, 2024
…#56202) Uses `ro.product.first_api_level` to disable AHBs on devices that began life pre 29. Fixes flutter/flutter#157113
|
reason for revert: tests didn't actually run. |
jonahwilliams
added
the
revert
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Oct 29, 2024
…#56202)" (#56212) Reverts: #56202 Initiated by: jonahwilliams Reason for reverting: tests didn't actually run. Original PR Author: jonahwilliams Reviewed By: {chinmaygarde, jtmcdole} This change reverts the following previous change: Uses `ro.product.first_api_level` to disable AHBs on devices that began life pre 29. Fixes flutter/flutter#157113
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 29, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 29, 2024
…157820) flutter/engine@725c8e4...795b549 2024-10-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] disable AHBs on devices that were upgraded to 29. (#56202)" (flutter/engine#56212) 2024-10-29 aam@google.com Remove --time run of gen_snapshot. (flutter/engine#56204) 2024-10-29 jason-simmons@users.noreply.github.com [Impeller] Clip the DrawImageRect source rect to the bounds of the image (flutter/engine#56183) 2024-10-29 jonahwilliams@google.com [Impeller] disable Maleoon GPU from using Vulkan. (flutter/engine#56203) 2024-10-29 jonahwilliams@google.com [Impeller] disable AHBs on devices that were upgraded to 29. (flutter/engine#56202) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
) (#56208) Uses `ro.product.first_api_level` to disable AHBs on devices that began life pre 29. Fixes flutter/flutter#157113
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…/engine#56202) Uses `ro.product.first_api_level` to disable AHBs on devices that began life pre 29. Fixes flutter#157113
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…flutter#56202)" (flutter/engine#56212) Reverts: flutter/engine#56202 Initiated by: jonahwilliams Reason for reverting: tests didn't actually run. Original PR Author: jonahwilliams Reviewed By: {chinmaygarde, jtmcdole} This change reverts the following previous change: Uses `ro.product.first_api_level` to disable AHBs on devices that began life pre 29. Fixes flutter#157113
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
ro.product.first_api_levelto disable AHBs on devices that began life pre 29.Fixes flutter/flutter#157113