-
Notifications
You must be signed in to change notification settings - Fork 6k
vulkan_glfw validation layer logging #54607
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
4d295da
to
1d30a10
Compare
-prints validation output when enable_validation_layers is enabled Signed-off-by: Joel Winarske <joel.winarske@gmail.com>
1d30a10
to
805cbda
Compare
@chinmaygarde I updated the run.sh to use the glfw main.dart; it was commented out prior, and I just pushed change to make it compatible with the GPU test I recently added to glfw main.dart. So it's ready to merge. |
…153994) flutter/engine@67a7fe1...e4fac78 2024-08-23 flar@google.com Revert "Framework wide color" (flutter/engine#54728) 2024-08-23 skia-flutter-autoroll@skia.org Roll Skia from 7ac776072577 to 7d96b8516e8d (3 revisions) (flutter/engine#54731) 2024-08-23 skia-flutter-autoroll@skia.org Roll Skia from 789f5cb0b9c2 to 7ac776072577 (1 revision) (flutter/engine#54729) 2024-08-23 skia-flutter-autoroll@skia.org Roll Skia from b25553b2fb9f to 789f5cb0b9c2 (1 revision) (flutter/engine#54726) 2024-08-23 skia-flutter-autoroll@skia.org Roll Dart SDK from ca009736fb3e to f9e6abb21ac7 (1 revision) (flutter/engine#54725) 2024-08-23 bdero@google.com [Impeller] Reland 3: Implement draw order optimization. (flutter/engine#54673) 2024-08-23 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from 2fOjXGNxdSoRSGCL7... to 2TaLkdJNlAIbDYccn... (flutter/engine#54721) 2024-08-23 skia-flutter-autoroll@skia.org Roll Fuchsia GN SDK from sbh76PYVTMxav4ACT... to OKGFjciA5Vd0TQks4... (flutter/engine#54722) 2024-08-22 magder@google.com Test running the macOS engine has no stray logging (flutter/engine#54716) 2024-08-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 937389f7bc48 to ca009736fb3e (1 revision) (flutter/engine#54719) 2024-08-22 matanlurey@users.noreply.github.com More diagnostic clean ups (flutter/engine#54265) 2024-08-22 30870216+gaaclarke@users.noreply.github.com Framework wide color (flutter/engine#54415) 2024-08-22 skia-flutter-autoroll@skia.org Roll Skia from 10e9072dcea0 to b25553b2fb9f (2 revisions) (flutter/engine#54717) 2024-08-22 skia-flutter-autoroll@skia.org Roll Dart SDK from ce160bf13347 to 937389f7bc48 (1 revision) (flutter/engine#54715) 2024-08-22 yjbanov@google.com [web:semantics] fix double click due to long-press (flutter/engine#54697) 2024-08-22 skia-flutter-autoroll@skia.org Roll Skia from 04ce2e2bfc35 to 10e9072dcea0 (1 revision) (flutter/engine#54713) 2024-08-22 zanderso@users.noreply.github.com Pin mac host and iOS builds to arm64 builders (flutter/engine#54711) 2024-08-22 chris@bracken.jp macOS: Bundle dSYM packages in FlutterMacOS.xcframework (flutter/engine#54696) 2024-08-22 skia-flutter-autoroll@skia.org Roll Skia from 7611984dc27b to 04ce2e2bfc35 (2 revisions) (flutter/engine#54712) 2024-08-22 joel.winarske@gmail.com vulkan_glfw validation layer logging (flutter/engine#54607) 2024-08-22 skia-flutter-autoroll@skia.org Roll Skia from 4c66b7e42027 to 7611984dc27b (1 revision) (flutter/engine#54710) 2024-08-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 025bf8d376d3 to ce160bf13347 (1 revision) (flutter/engine#54709) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#153994) flutter/engine@67a7fe1...e4fac78 2024-08-23 flar@google.com Revert "Framework wide color" (flutter/engine#54728) 2024-08-23 skia-flutter-autoroll@skia.org Roll Skia from 7ac776072577 to 7d96b8516e8d (3 revisions) (flutter/engine#54731) 2024-08-23 skia-flutter-autoroll@skia.org Roll Skia from 789f5cb0b9c2 to 7ac776072577 (1 revision) (flutter/engine#54729) 2024-08-23 skia-flutter-autoroll@skia.org Roll Skia from b25553b2fb9f to 789f5cb0b9c2 (1 revision) (flutter/engine#54726) 2024-08-23 skia-flutter-autoroll@skia.org Roll Dart SDK from ca009736fb3e to f9e6abb21ac7 (1 revision) (flutter/engine#54725) 2024-08-23 bdero@google.com [Impeller] Reland 3: Implement draw order optimization. (flutter/engine#54673) 2024-08-23 skia-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from 2fOjXGNxdSoRSGCL7... to 2TaLkdJNlAIbDYccn... (flutter/engine#54721) 2024-08-23 skia-flutter-autoroll@skia.org Roll Fuchsia GN SDK from sbh76PYVTMxav4ACT... to OKGFjciA5Vd0TQks4... (flutter/engine#54722) 2024-08-22 magder@google.com Test running the macOS engine has no stray logging (flutter/engine#54716) 2024-08-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 937389f7bc48 to ca009736fb3e (1 revision) (flutter/engine#54719) 2024-08-22 matanlurey@users.noreply.github.com More diagnostic clean ups (flutter/engine#54265) 2024-08-22 30870216+gaaclarke@users.noreply.github.com Framework wide color (flutter/engine#54415) 2024-08-22 skia-flutter-autoroll@skia.org Roll Skia from 10e9072dcea0 to b25553b2fb9f (2 revisions) (flutter/engine#54717) 2024-08-22 skia-flutter-autoroll@skia.org Roll Dart SDK from ce160bf13347 to 937389f7bc48 (1 revision) (flutter/engine#54715) 2024-08-22 yjbanov@google.com [web:semantics] fix double click due to long-press (flutter/engine#54697) 2024-08-22 skia-flutter-autoroll@skia.org Roll Skia from 04ce2e2bfc35 to 10e9072dcea0 (1 revision) (flutter/engine#54713) 2024-08-22 zanderso@users.noreply.github.com Pin mac host and iOS builds to arm64 builders (flutter/engine#54711) 2024-08-22 chris@bracken.jp macOS: Bundle dSYM packages in FlutterMacOS.xcframework (flutter/engine#54696) 2024-08-22 skia-flutter-autoroll@skia.org Roll Skia from 7611984dc27b to 04ce2e2bfc35 (2 revisions) (flutter/engine#54712) 2024-08-22 joel.winarske@gmail.com vulkan_glfw validation layer logging (flutter/engine#54607) 2024-08-22 skia-flutter-autoroll@skia.org Roll Skia from 4c66b7e42027 to 7611984dc27b (1 revision) (flutter/engine#54710) 2024-08-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 025bf8d376d3 to ce160bf13347 (1 revision) (flutter/engine#54709) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This PR enables printing validation output when the Vulkan validation layer is enabled. Without this change no messages are printed which provides a false positive for the Vulkan Embedder API health.
List which issues are fixed by this PR. You must list at least one issue.
flutter/flutter#153663
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.
cc @chinmaygarde
Fixes flutter/flutter#153663