This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] convert aiks blur tests to new canvas. #54565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o more_more_tests
chinmaygarde
approved these changes
Aug 15, 2024
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 15, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 15, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 15, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 15, 2024
…ions) (#153525) Manual roll requested by zra@google.com flutter/engine@971ddd9...8f3f80e 2024-08-15 jonahwilliams@google.com [Impeller] revert experimental canvas. (flutter/engine#54570) 2024-08-15 69794332+smart7even@users.noreply.github.com Fix typo in AppLifecycleState documentation (flutter/engine#54544) 2024-08-15 codefu@google.com Update RBE troubleshooting (flutter/engine#54568) 2024-08-15 jonahwilliams@google.com [Impeller] Switch from AIKS canvas to DL based canvas implementation. (flutter/engine#53781) 2024-08-15 jonahwilliams@google.com [Impeller] convert aiks blur tests to new canvas. (flutter/engine#54565) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
DBowen33
pushed a commit
to DBowen33/flutter
that referenced
this pull request
Aug 16, 2024
…ions) (flutter#153525) Manual roll requested by zra@google.com flutter/engine@971ddd9...8f3f80e 2024-08-15 jonahwilliams@google.com [Impeller] revert experimental canvas. (flutter/engine#54570) 2024-08-15 69794332+smart7even@users.noreply.github.com Fix typo in AppLifecycleState documentation (flutter/engine#54544) 2024-08-15 codefu@google.com Update RBE troubleshooting (flutter/engine#54568) 2024-08-15 jonahwilliams@google.com [Impeller] Switch from AIKS canvas to DL based canvas implementation. (flutter/engine#53781) 2024-08-15 jonahwilliams@google.com [Impeller] convert aiks blur tests to new canvas. (flutter/engine#54565) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…ions) (flutter#153525) Manual roll requested by zra@google.com flutter/engine@971ddd9...8f3f80e 2024-08-15 jonahwilliams@google.com [Impeller] revert experimental canvas. (flutter/engine#54570) 2024-08-15 69794332+smart7even@users.noreply.github.com Fix typo in AppLifecycleState documentation (flutter/engine#54544) 2024-08-15 codefu@google.com Update RBE troubleshooting (flutter/engine#54568) 2024-08-15 jonahwilliams@google.com [Impeller] Switch from AIKS canvas to DL based canvas implementation. (flutter/engine#53781) 2024-08-15 jonahwilliams@google.com [Impeller] convert aiks blur tests to new canvas. (flutter/engine#54565) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of DL interop. Currently experiencing some ... issues with blur radius/sigma.
EDIT: was rrect_blur vs gaussian: fixed now.
Part of flutter/flutter#142054
Reland because of CI issue?