Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[DisplayList] benchmark DisplayList dispatch method #54324

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

flar
Copy link
Contributor

@flar flar commented Aug 2, 2024

We will be updating the DisplayList dispatching to support random access iteration through the records so we need a benchmark to set a baseline to track any impact on the default way to dispatch a DisplayList.

@flar flar requested a review from jonahwilliams August 2, 2024 22:35
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 3, 2024
@auto-submit auto-submit bot merged commit 2a51c68 into flutter:main Aug 3, 2024
29 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 3, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Aug 3, 2024
…152818)

flutter/engine@4c868ee...2a51c68

2024-08-03 flar@google.com [DisplayList] benchmark DisplayList dispatch method (flutter/engine#54324)
2024-08-03 skia-flutter-autoroll@skia.org Roll Skia from 60c660ecdf0a to 8f0e1486b887 (1 revision) (flutter/engine#54331)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
…lutter#152818)

flutter/engine@4c868ee...2a51c68

2024-08-03 flar@google.com [DisplayList] benchmark DisplayList dispatch method (flutter/engine#54324)
2024-08-03 skia-flutter-autoroll@skia.org Roll Skia from 60c660ecdf0a to 8f0e1486b887 (1 revision) (flutter/engine#54331)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
…lutter#152818)

flutter/engine@4c868ee...2a51c68

2024-08-03 flar@google.com [DisplayList] benchmark DisplayList dispatch method (flutter/engine#54324)
2024-08-03 skia-flutter-autoroll@skia.org Roll Skia from 60c660ecdf0a to 8f0e1486b887 (1 revision) (flutter/engine#54331)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants