This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] remove varying interpolation for solid colors. #53281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
approved these changes
Jun 7, 2024
| @@ -60,7 +63,8 @@ bool SolidColorContents::Render(const ContentContext& renderer, | |||
| }; | |||
| return ColorSourceContents::DrawGeometry<VS>( | |||
| renderer, entity, pass, pipeline_callback, frame_info, | |||
| [](RenderPass& pass) { | |||
| [&frag_info, &host_buffer](RenderPass& pass) { | |||
| FS::BindFragInfo(pass, host_buffer.EmplaceUniform(frag_info)); | |||
There was a problem hiding this comment.
Unrelated to this PR, but "EmplaceUniform" is a poor name if it isn't taking in an rvalue.
| @@ -60,7 +63,8 @@ bool SolidColorContents::Render(const ContentContext& renderer, | |||
| }; | |||
| return ColorSourceContents::DrawGeometry<VS>( | |||
| renderer, entity, pass, pipeline_callback, frame_info, | |||
| [](RenderPass& pass) { | |||
| [&frag_info, &host_buffer](RenderPass& pass) { | |||
There was a problem hiding this comment.
Note: This callback is used synchronously with DrawGeometry, so the fact it is capturing references looks good.
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 11, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 12, 2024
…150069) Roll Flutter Engine from 1cdbebee1901 to c7fcbfce608f (54 revisions) flutter/engine@1cdbebe...c7fcbfc 2024-06-11 jason-simmons@users.noreply.github.com Fix character getter API usage in stripLeftSlashes/stripRightSlashes (flutter/engine#53299) 2024-06-11 yjbanov@google.com [web] switch from .didGain/LoseAccessibilityFocus to .focus (flutter/engine#53134) 2024-06-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 282b3347dc3e to ab4d5a0b789d (1 revision) (flutter/engine#53338) 2024-06-11 bdero@google.com [Flutter GPU] Generate DescriptorSetLayouts for pipelines & export symbols on Android. (flutter/engine#53184) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from cd2249d1ba33 to b5f974ec2dcd (4 revisions) (flutter/engine#53337) 2024-06-11 jonahwilliams@google.com [Impeller] remove varying interpolation for solid colors. (flutter/engine#53281) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from 67c3ee616fb5 to cd2249d1ba33 (4 revisions) (flutter/engine#53335) 2024-06-11 jonahwilliams@google.com [engine] null check texture registry in OnPlatformViewMarkTextureFrameAvailable. (flutter/engine#53334) 2024-06-11 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 66ed61abe85e to 282b3347dc3e (4 revisions) (flutter/engine#53332) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from 74061baa5402 to 67c3ee616fb5 (2 revisions) (flutter/engine#53333) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from f4d3467f2742 to 74061baa5402 (1 revision) (flutter/engine#53331) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from 5afbe0a7aded to f4d3467f2742 (1 revision) (flutter/engine#53330) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from eb8a53033e88 to 5afbe0a7aded (1 revision) (flutter/engine#53328) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from ed92d84ffd3a to eb8a53033e88 (1 revision) (flutter/engine#53327) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from 6e7a7a72cf3e to ed92d84ffd3a (5 revisions) (flutter/engine#53326) 2024-06-11 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.6 to 3.25.8 (flutter/engine#53325) 2024-06-11 49699333+dependabot[bot]@users.noreply.github.com Bump google/osv-scanner-action from 1.7.3 to 1.7.4 (flutter/engine#53324) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from b2bc3608f5c7 to 6e7a7a72cf3e (1 revision) (flutter/engine#53323) 2024-06-11 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 235dc289e4bf to 66ed61abe85e (5 revisions) (flutter/engine#53319) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from 38733e27e0d2 to b2bc3608f5c7 (1 revision) (flutter/engine#53321) 2024-06-10 15619084+vashworth@users.noreply.github.com Temporarily run Linux linux_web_engine Mac tests on Mac-13 only (flutter/engine#53318) 2024-06-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from -oOBf1l63tk7CztFd... to LS0Ff8PwQEGXzO0iA... (flutter/engine#53317) 2024-06-10 smartercallum@gmail.com Map mouse pointer type on Linux (flutter/engine#52418) 2024-06-10 skia-flutter-autoroll@skia.org Roll Skia from 09cebc502599 to 38733e27e0d2 (1 revision) (flutter/engine#53316) 2024-06-10 15619084+vashworth@users.noreply.github.com Temporarily run Mac mac_host_engine on only Mac-13 (flutter/engine#53313) 2024-06-10 skia-flutter-autoroll@skia.org Roll Skia from 178953621308 to 09cebc502599 (1 revision) (flutter/engine#53312) 2024-06-10 skia-flutter-autoroll@skia.org Roll Skia from 009d184e82c5 to 178953621308 (2 revisions) (flutter/engine#53311) 2024-06-10 skia-flutter-autoroll@skia.org Roll Skia from 163df01252cd to 009d184e82c5 (1 revision) (flutter/engine#53309) 2024-06-10 kustermann@google.com Use dart.library.html to distinguish dart2wasm from dart2js/ddc in conditional imports (flutter/engine#53307) 2024-06-10 skia-flutter-autoroll@skia.org Roll Skia from 74b1e88878e1 to 163df01252cd (1 revision) (flutter/engine#53308) 2024-06-10 kustermann@google.com Use new dart:js_interop way to externalize/internalize objects (flutter/engine#53304) 2024-06-10 skia-flutter-autoroll@skia.org Roll Skia from 09e5ddcd4d23 to 74b1e88878e1 (1 revision) (flutter/engine#53305) 2024-06-10 skia-flutter-autoroll@skia.org Roll Skia from e22a628e1ee0 to 09e5ddcd4d23 (1 revision) (flutter/engine#53302) 2024-06-10 skia-flutter-autoroll@skia.org Roll Skia from 70d479753d41 to e22a628e1ee0 (2 revisions) (flutter/engine#53301) 2024-06-10 skia-flutter-autoroll@skia.org Roll Skia from aafc81dcd88d to 70d479753d41 (1 revision) (flutter/engine#53300) 2024-06-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 8-r8iw3r4h35XQ4GP... to -oOBf1l63tk7CztFd... (flutter/engine#53298) 2024-06-09 skia-flutter-autoroll@skia.org Roll Skia from 7d410bf13546 to aafc81dcd88d (1 revision) (flutter/engine#53297) 2024-06-08 bdero@google.com [Impeller] Move SeparatedVector2 to impeller/geometry. (flutter/engine#53264) 2024-06-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from zpBZmUB_JC5AjG-f4... to 8-r8iw3r4h35XQ4GP... (flutter/engine#53291) 2024-06-08 skia-flutter-autoroll@skia.org Roll Skia from a6c905943fe6 to 7d410bf13546 (1 revision) (flutter/engine#53290) 2024-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from 48c6249a5b97 to 235dc289e4bf (1 revision) (flutter/engine#53289) 2024-06-08 skia-flutter-autoroll@skia.org Roll Skia from ad3c9f203f4e to a6c905943fe6 (1 revision) (flutter/engine#53288) 2024-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from d4f17e0bf28b to 48c6249a5b97 (1 revision) (flutter/engine#53287) 2024-06-08 30870216+gaaclarke@users.noreply.github.com [impeller] switches gaussian blur to a "source space" calculation (flutter/engine#53261) 2024-06-07 yjbanov@google.com [web] add test for inefficient overlay allocation (flutter/engine#53284) 2024-06-07 jacksongardner@google.com Update Chrome to 125. (flutter/engine#53282) ...
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jun 14, 2024
…lutter#150069) Roll Flutter Engine from 1cdbebee1901 to c7fcbfce608f (54 revisions) flutter/engine@1cdbebe...c7fcbfc 2024-06-11 jason-simmons@users.noreply.github.com Fix character getter API usage in stripLeftSlashes/stripRightSlashes (flutter/engine#53299) 2024-06-11 yjbanov@google.com [web] switch from .didGain/LoseAccessibilityFocus to .focus (flutter/engine#53134) 2024-06-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 282b3347dc3e to ab4d5a0b789d (1 revision) (flutter/engine#53338) 2024-06-11 bdero@google.com [Flutter GPU] Generate DescriptorSetLayouts for pipelines & export symbols on Android. (flutter/engine#53184) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from cd2249d1ba33 to b5f974ec2dcd (4 revisions) (flutter/engine#53337) 2024-06-11 jonahwilliams@google.com [Impeller] remove varying interpolation for solid colors. (flutter/engine#53281) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from 67c3ee616fb5 to cd2249d1ba33 (4 revisions) (flutter/engine#53335) 2024-06-11 jonahwilliams@google.com [engine] null check texture registry in OnPlatformViewMarkTextureFrameAvailable. (flutter/engine#53334) 2024-06-11 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 66ed61abe85e to 282b3347dc3e (4 revisions) (flutter/engine#53332) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from 74061baa5402 to 67c3ee616fb5 (2 revisions) (flutter/engine#53333) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from f4d3467f2742 to 74061baa5402 (1 revision) (flutter/engine#53331) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from 5afbe0a7aded to f4d3467f2742 (1 revision) (flutter/engine#53330) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from eb8a53033e88 to 5afbe0a7aded (1 revision) (flutter/engine#53328) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from ed92d84ffd3a to eb8a53033e88 (1 revision) (flutter/engine#53327) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from 6e7a7a72cf3e to ed92d84ffd3a (5 revisions) (flutter/engine#53326) 2024-06-11 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.6 to 3.25.8 (flutter/engine#53325) 2024-06-11 49699333+dependabot[bot]@users.noreply.github.com Bump google/osv-scanner-action from 1.7.3 to 1.7.4 (flutter/engine#53324) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from b2bc3608f5c7 to 6e7a7a72cf3e (1 revision) (flutter/engine#53323) 2024-06-11 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 235dc289e4bf to 66ed61abe85e (5 revisions) (flutter/engine#53319) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from 38733e27e0d2 to b2bc3608f5c7 (1 revision) (flutter/engine#53321) 2024-06-10 15619084+vashworth@users.noreply.github.com Temporarily run Linux linux_web_engine Mac tests on Mac-13 only (flutter/engine#53318) 2024-06-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from -oOBf1l63tk7CztFd... to LS0Ff8PwQEGXzO0iA... (flutter/engine#53317) 2024-06-10 smartercallum@gmail.com Map mouse pointer type on Linux (flutter/engine#52418) 2024-06-10 skia-flutter-autoroll@skia.org Roll Skia from 09cebc502599 to 38733e27e0d2 (1 revision) (flutter/engine#53316) 2024-06-10 15619084+vashworth@users.noreply.github.com Temporarily run Mac mac_host_engine on only Mac-13 (flutter/engine#53313) 2024-06-10 skia-flutter-autoroll@skia.org Roll Skia from 178953621308 to 09cebc502599 (1 revision) (flutter/engine#53312) 2024-06-10 skia-flutter-autoroll@skia.org Roll Skia from 009d184e82c5 to 178953621308 (2 revisions) (flutter/engine#53311) 2024-06-10 skia-flutter-autoroll@skia.org Roll Skia from 163df01252cd to 009d184e82c5 (1 revision) (flutter/engine#53309) 2024-06-10 kustermann@google.com Use dart.library.html to distinguish dart2wasm from dart2js/ddc in conditional imports (flutter/engine#53307) 2024-06-10 skia-flutter-autoroll@skia.org Roll Skia from 74b1e88878e1 to 163df01252cd (1 revision) (flutter/engine#53308) 2024-06-10 kustermann@google.com Use new dart:js_interop way to externalize/internalize objects (flutter/engine#53304) 2024-06-10 skia-flutter-autoroll@skia.org Roll Skia from 09e5ddcd4d23 to 74b1e88878e1 (1 revision) (flutter/engine#53305) 2024-06-10 skia-flutter-autoroll@skia.org Roll Skia from e22a628e1ee0 to 09e5ddcd4d23 (1 revision) (flutter/engine#53302) 2024-06-10 skia-flutter-autoroll@skia.org Roll Skia from 70d479753d41 to e22a628e1ee0 (2 revisions) (flutter/engine#53301) 2024-06-10 skia-flutter-autoroll@skia.org Roll Skia from aafc81dcd88d to 70d479753d41 (1 revision) (flutter/engine#53300) 2024-06-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 8-r8iw3r4h35XQ4GP... to -oOBf1l63tk7CztFd... (flutter/engine#53298) 2024-06-09 skia-flutter-autoroll@skia.org Roll Skia from 7d410bf13546 to aafc81dcd88d (1 revision) (flutter/engine#53297) 2024-06-08 bdero@google.com [Impeller] Move SeparatedVector2 to impeller/geometry. (flutter/engine#53264) 2024-06-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from zpBZmUB_JC5AjG-f4... to 8-r8iw3r4h35XQ4GP... (flutter/engine#53291) 2024-06-08 skia-flutter-autoroll@skia.org Roll Skia from a6c905943fe6 to 7d410bf13546 (1 revision) (flutter/engine#53290) 2024-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from 48c6249a5b97 to 235dc289e4bf (1 revision) (flutter/engine#53289) 2024-06-08 skia-flutter-autoroll@skia.org Roll Skia from ad3c9f203f4e to a6c905943fe6 (1 revision) (flutter/engine#53288) 2024-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from d4f17e0bf28b to 48c6249a5b97 (1 revision) (flutter/engine#53287) 2024-06-08 30870216+gaaclarke@users.noreply.github.com [impeller] switches gaussian blur to a "source space" calculation (flutter/engine#53261) 2024-06-07 yjbanov@google.com [web] add test for inefficient overlay allocation (flutter/engine#53284) 2024-06-07 jacksongardner@google.com Update Chrome to 125. (flutter/engine#53282) ...
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jun 14, 2024
…lutter#150069) Roll Flutter Engine from 1cdbebee1901 to c7fcbfce608f (54 revisions) flutter/engine@1cdbebe...c7fcbfc 2024-06-11 jason-simmons@users.noreply.github.com Fix character getter API usage in stripLeftSlashes/stripRightSlashes (flutter/engine#53299) 2024-06-11 yjbanov@google.com [web] switch from .didGain/LoseAccessibilityFocus to .focus (flutter/engine#53134) 2024-06-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 282b3347dc3e to ab4d5a0b789d (1 revision) (flutter/engine#53338) 2024-06-11 bdero@google.com [Flutter GPU] Generate DescriptorSetLayouts for pipelines & export symbols on Android. (flutter/engine#53184) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from cd2249d1ba33 to b5f974ec2dcd (4 revisions) (flutter/engine#53337) 2024-06-11 jonahwilliams@google.com [Impeller] remove varying interpolation for solid colors. (flutter/engine#53281) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from 67c3ee616fb5 to cd2249d1ba33 (4 revisions) (flutter/engine#53335) 2024-06-11 jonahwilliams@google.com [engine] null check texture registry in OnPlatformViewMarkTextureFrameAvailable. (flutter/engine#53334) 2024-06-11 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 66ed61abe85e to 282b3347dc3e (4 revisions) (flutter/engine#53332) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from 74061baa5402 to 67c3ee616fb5 (2 revisions) (flutter/engine#53333) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from f4d3467f2742 to 74061baa5402 (1 revision) (flutter/engine#53331) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from 5afbe0a7aded to f4d3467f2742 (1 revision) (flutter/engine#53330) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from eb8a53033e88 to 5afbe0a7aded (1 revision) (flutter/engine#53328) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from ed92d84ffd3a to eb8a53033e88 (1 revision) (flutter/engine#53327) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from 6e7a7a72cf3e to ed92d84ffd3a (5 revisions) (flutter/engine#53326) 2024-06-11 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.6 to 3.25.8 (flutter/engine#53325) 2024-06-11 49699333+dependabot[bot]@users.noreply.github.com Bump google/osv-scanner-action from 1.7.3 to 1.7.4 (flutter/engine#53324) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from b2bc3608f5c7 to 6e7a7a72cf3e (1 revision) (flutter/engine#53323) 2024-06-11 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 235dc289e4bf to 66ed61abe85e (5 revisions) (flutter/engine#53319) 2024-06-11 skia-flutter-autoroll@skia.org Roll Skia from 38733e27e0d2 to b2bc3608f5c7 (1 revision) (flutter/engine#53321) 2024-06-10 15619084+vashworth@users.noreply.github.com Temporarily run Linux linux_web_engine Mac tests on Mac-13 only (flutter/engine#53318) 2024-06-10 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from -oOBf1l63tk7CztFd... to LS0Ff8PwQEGXzO0iA... (flutter/engine#53317) 2024-06-10 smartercallum@gmail.com Map mouse pointer type on Linux (flutter/engine#52418) 2024-06-10 skia-flutter-autoroll@skia.org Roll Skia from 09cebc502599 to 38733e27e0d2 (1 revision) (flutter/engine#53316) 2024-06-10 15619084+vashworth@users.noreply.github.com Temporarily run Mac mac_host_engine on only Mac-13 (flutter/engine#53313) 2024-06-10 skia-flutter-autoroll@skia.org Roll Skia from 178953621308 to 09cebc502599 (1 revision) (flutter/engine#53312) 2024-06-10 skia-flutter-autoroll@skia.org Roll Skia from 009d184e82c5 to 178953621308 (2 revisions) (flutter/engine#53311) 2024-06-10 skia-flutter-autoroll@skia.org Roll Skia from 163df01252cd to 009d184e82c5 (1 revision) (flutter/engine#53309) 2024-06-10 kustermann@google.com Use dart.library.html to distinguish dart2wasm from dart2js/ddc in conditional imports (flutter/engine#53307) 2024-06-10 skia-flutter-autoroll@skia.org Roll Skia from 74b1e88878e1 to 163df01252cd (1 revision) (flutter/engine#53308) 2024-06-10 kustermann@google.com Use new dart:js_interop way to externalize/internalize objects (flutter/engine#53304) 2024-06-10 skia-flutter-autoroll@skia.org Roll Skia from 09e5ddcd4d23 to 74b1e88878e1 (1 revision) (flutter/engine#53305) 2024-06-10 skia-flutter-autoroll@skia.org Roll Skia from e22a628e1ee0 to 09e5ddcd4d23 (1 revision) (flutter/engine#53302) 2024-06-10 skia-flutter-autoroll@skia.org Roll Skia from 70d479753d41 to e22a628e1ee0 (2 revisions) (flutter/engine#53301) 2024-06-10 skia-flutter-autoroll@skia.org Roll Skia from aafc81dcd88d to 70d479753d41 (1 revision) (flutter/engine#53300) 2024-06-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 8-r8iw3r4h35XQ4GP... to -oOBf1l63tk7CztFd... (flutter/engine#53298) 2024-06-09 skia-flutter-autoroll@skia.org Roll Skia from 7d410bf13546 to aafc81dcd88d (1 revision) (flutter/engine#53297) 2024-06-08 bdero@google.com [Impeller] Move SeparatedVector2 to impeller/geometry. (flutter/engine#53264) 2024-06-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from zpBZmUB_JC5AjG-f4... to 8-r8iw3r4h35XQ4GP... (flutter/engine#53291) 2024-06-08 skia-flutter-autoroll@skia.org Roll Skia from a6c905943fe6 to 7d410bf13546 (1 revision) (flutter/engine#53290) 2024-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from 48c6249a5b97 to 235dc289e4bf (1 revision) (flutter/engine#53289) 2024-06-08 skia-flutter-autoroll@skia.org Roll Skia from ad3c9f203f4e to a6c905943fe6 (1 revision) (flutter/engine#53288) 2024-06-08 skia-flutter-autoroll@skia.org Roll Dart SDK from d4f17e0bf28b to 48c6249a5b97 (1 revision) (flutter/engine#53287) 2024-06-08 30870216+gaaclarke@users.noreply.github.com [impeller] switches gaussian blur to a "source space" calculation (flutter/engine#53261) 2024-06-07 yjbanov@google.com [web] add test for inefficient overlay allocation (flutter/engine#53284) 2024-06-07 jacksongardner@google.com Update Chrome to 125. (flutter/engine#53282) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an early attempt to support batching that ended up not being important, as well as an attempted work around for high memory reads that ended being unrelated (it was blending)
Since its not a performance improvement and just makes things more complicated, remove the feature.