Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Add 'flt-semantics-identifier' attribute to semantics nodes #53278

Merged
merged 4 commits into from
Jun 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions lib/web_ui/lib/src/engine/semantics/semantics.dart
Original file line number Diff line number Diff line change
Expand Up @@ -612,6 +612,18 @@ abstract class PrimaryRoleManager {
for (final RoleManager secondaryRole in secondaryRoles) {
secondaryRole.update();
}

if (semanticsObject.isIdentifierDirty) {
_updateIdentifier();
}
}

void _updateIdentifier() {
if (semanticsObject.hasIdentifier) {
setAttribute('flt-semantics-identifier', semanticsObject.identifier!);
} else {
removeAttribute('flt-semantics-identifier');
}
}

/// Whether this role manager was disposed of.
Expand Down Expand Up @@ -1119,6 +1131,21 @@ class SemanticsObject {
_dirtyFields |= _headingLevelIndex;
}

/// See [ui.SemanticsUpdateBuilder.updateNode].
String? get identifier => _identifier;
String? _identifier;

bool get hasIdentifier => _identifier != null && _identifier!.isNotEmpty;

static const int _identifierIndex = 1 << 25;

/// Whether the [identifier] field has been updated but has not been
/// applied to the DOM yet.
bool get isIdentifierDirty => _isDirty(_identifierIndex);
void _markIdentifierDirty() {
_dirtyFields |= _identifierIndex;
}

/// A unique permanent identifier of the semantics node in the tree.
final int id;

Expand Down Expand Up @@ -1278,6 +1305,11 @@ class SemanticsObject {
_markFlagsDirty();
}

if (_identifier != update.identifier) {
_identifier = update.identifier;
_markIdentifierDirty();
}

if (_value != update.value) {
_value = update.value;
_markValueDirty();
Expand Down
65 changes: 65 additions & 0 deletions lib/web_ui/test/engine/semantics/semantics_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ void runSemanticsTests() {
group('longestIncreasingSubsequence', () {
_testLongestIncreasingSubsequence();
});
group(PrimaryRoleManager, () {
_testPrimaryRoleManager();
});
group('Role managers', () {
_testRoleManagerLifecycle();
});
Expand Down Expand Up @@ -107,6 +110,68 @@ void runSemanticsTests() {
});
}

void _testPrimaryRoleManager() {
test('Sets id and flt-semantics-identifier on the element', () {
semantics()
..debugOverrideTimestampFunction(() => _testTime)
..semanticsEnabled = true;

final SemanticsTester tester = SemanticsTester(owner());
tester.updateNode(
id: 0,
children: <SemanticsNodeUpdate>[
tester.updateNode(id: 372),
tester.updateNode(id: 599),
],
);
tester.apply();

tester.expectSemantics('''
<sem id="flt-semantic-node-0">
<sem-c>
<sem id="flt-semantic-node-372"></sem>
<sem id="flt-semantic-node-599"></sem>
</sem-c>
</sem>''');

tester.updateNode(
id: 0,
children: <SemanticsNodeUpdate>[
tester.updateNode(id: 372, identifier: 'test-id-123'),
tester.updateNode(id: 599),
],
);
tester.apply();

tester.expectSemantics('''
<sem id="flt-semantic-node-0">
<sem-c>
<sem id="flt-semantic-node-372" flt-semantics-identifier="test-id-123"></sem>
<sem id="flt-semantic-node-599"></sem>
</sem-c>
</sem>''');

tester.updateNode(
id: 0,
children: <SemanticsNodeUpdate>[
tester.updateNode(id: 372),
tester.updateNode(id: 599, identifier: 'test-id-211'),
tester.updateNode(id: 612, identifier: 'test-id-333'),
],
);
tester.apply();

tester.expectSemantics('''
<sem id="flt-semantic-node-0">
<sem-c>
<sem id="flt-semantic-node-372"></sem>
<sem id="flt-semantic-node-599" flt-semantics-identifier="test-id-211"></sem>
<sem id="flt-semantic-node-612" flt-semantics-identifier="test-id-333"></sem>
</sem-c>
</sem>''');
});
}

void _testRoleManagerLifecycle() {
test('Secondary role managers are added upon node initialization', () {
semantics()
Expand Down