This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix another instance of platform view breakage on Android 14 #52980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you background an activity via the back-gesture the onTrimMemory callback is not invoked but the buggy Android behaviour still occurs. Workaround this by faking an onTrimMemory callback in the `Activity#onStop` callback. Fixes #148662 Related #146499
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
johnmccutchan
added
the
autosubmit
reidbaker
added
the
cp: stable
flutteractionsbot
pushed a commit
to flutteractionsbot/engine
that referenced
this pull request
May 22, 2024
…#52980) When you background an activity via the back-gesture the onTrimMemory callback is not invoked but the buggy Android behaviour still occurs. Workaround this by faking an onTrimMemory callback in the `Activity#onStop` callback. Fixes #148662 Related #146499 Tested manually on a Pixel 7 Pro running Android 14.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 22, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 23, 2024
…148919) flutter/engine@8b094fb...b8b8245 2024-05-22 skia-flutter-autoroll@skia.org Roll Skia from 380ae98608de to 0ee149894a8d (5 revisions) (flutter/engine#52989) 2024-05-22 skia-flutter-autoroll@skia.org Roll Skia from 396c66076ab1 to 380ae98608de (4 revisions) (flutter/engine#52983) 2024-05-22 john@johnmccutchan.com Reduce rebuild times when invoking 'et run' (flutter/engine#52883) 2024-05-22 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Add dilate and erode imagefilters (flutter/engine#48553) 2024-05-22 skia-flutter-autoroll@skia.org Roll Skia from 93ed643df6d1 to 396c66076ab1 (3 revisions) (flutter/engine#52981) 2024-05-22 john@johnmccutchan.com Fix another instance of platform view breakage on Android 14 (flutter/engine#52980) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
…lutter#148919) flutter/engine@8b094fb...b8b8245 2024-05-22 skia-flutter-autoroll@skia.org Roll Skia from 380ae98608de to 0ee149894a8d (5 revisions) (flutter/engine#52989) 2024-05-22 skia-flutter-autoroll@skia.org Roll Skia from 396c66076ab1 to 380ae98608de (4 revisions) (flutter/engine#52983) 2024-05-22 john@johnmccutchan.com Reduce rebuild times when invoking 'et run' (flutter/engine#52883) 2024-05-22 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Add dilate and erode imagefilters (flutter/engine#48553) 2024-05-22 skia-flutter-autoroll@skia.org Roll Skia from 93ed643df6d1 to 396c66076ab1 (3 revisions) (flutter/engine#52981) 2024-05-22 john@johnmccutchan.com Fix another instance of platform view breakage on Android 14 (flutter/engine#52980) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you background an activity via the back-gesture the onTrimMemory callback is not invoked but the buggy Android behaviour still occurs.
Workaround this by faking an onTrimMemory callback in the
Activity#onStopcallback.Fixes #148662
Related #146499
Tested manually on a Pixel 7 Pro running Android 14.