This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove the view ID check in macOS/FlutterCompositor
#51852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkwingsmt
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 2, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 3, 2024
…146163) flutter/engine@5dbcfdc...5f6dec8 2024-04-02 dkwingsmt@users.noreply.github.com Remove the view ID check in `macOS/FlutterCompositor` (flutter/engine#51852) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the view ID check added in #51738, which has been causing a test
FlutterEngineTest.CompositorIgnoresUnknownView, added in #51436, to fail.This problem was missed by the CI because the test and the view ID check were added in two PRs recently and they were not using the latest engine to check.
The view ID check is not needed anyway, and is only a temporary check until the multiview support is landed.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.