This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Disable framework smoke tests. #50800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanlurey
approved these changes
Feb 20, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 21, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 21, 2024
…143807) flutter/engine@cb12a8c...3557277 2024-02-21 jonahwilliams@google.com Disable framework smoke tests. (flutter/engine#50800) 2024-02-20 jonahwilliams@google.com [Impeller] more nullchecks in image decoder. (flutter/engine#50787) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
For posterity, these tests were originally added in #8664. I don't quite follow the rationale for adding them, but maybe @chinmaygarde remembers what led up to that point? |
|
Nope. No recollection of this. |
8 tasks
|
This test usually caught dart:ui engine breakage. See #52421 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not think these tests have value and/or are running in the correct place. These tests almost never fail. When they do fail, it is often due to an unrelated breakage in the framework