Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[engine_build_configs] Use dart:ffi Abi to determine the host cpu #50604

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

zanderso
Copy link
Member

Follow-up on #50543 (comment)

Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL

@zanderso zanderso added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 13, 2024
Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@auto-submit auto-submit bot merged commit 933b97a into flutter:main Feb 13, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 13, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 13, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 13, 2024
…143393)

flutter/engine@8742f1c...0091a49

2024-02-13 jonahwilliams@google.com [Impeller] remove denylist entry. (flutter/engine#50605)
2024-02-13 zanderso@users.noreply.github.com [engine_build_configs] Use dart:ffi Abi to determine the host cpu (flutter/engine#50604)
2024-02-13 jason-simmons@users.noreply.github.com Update embedder support for Impeller/OpenGL to load some missing shaders and configure a depth attachment (flutter/engine#50416)
2024-02-13 skia-flutter-autoroll@skia.org Roll Skia from 30bba7419898 to f7e3a5395fe1 (1 revision) (flutter/engine#50603)
2024-02-13 30870216+gaaclarke@users.noreply.github.com [Impeller] replaced playground macros with functions (flutter/engine#50602)
2024-02-13 matanlurey@users.noreply.github.com Allow deprecated members from the Dart SDK to roll in. (flutter/engine#50575)
2024-02-13 6844906+zijiehe-google-com@users.noreply.github.com [Fuchsia] Run tests with test arguments (flutter/engine#50478)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants