This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
[Fuchsia] Run tests with test arguments #50478
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrwang
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with changes
CaseyHillers
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, the new test suite run_tests_test.py is added and running correctly. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 13, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 13, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 13, 2024
…143393) flutter/engine@8742f1c...0091a49 2024-02-13 jonahwilliams@google.com [Impeller] remove denylist entry. (flutter/engine#50605) 2024-02-13 zanderso@users.noreply.github.com [engine_build_configs] Use dart:ffi Abi to determine the host cpu (flutter/engine#50604) 2024-02-13 jason-simmons@users.noreply.github.com Update embedder support for Impeller/OpenGL to load some missing shaders and configure a depth attachment (flutter/engine#50416) 2024-02-13 skia-flutter-autoroll@skia.org Roll Skia from 30bba7419898 to f7e3a5395fe1 (1 revision) (flutter/engine#50603) 2024-02-13 30870216+gaaclarke@users.noreply.github.com [Impeller] replaced playground macros with functions (flutter/engine#50602) 2024-02-13 matanlurey@users.noreply.github.com Allow deprecated members from the Dart SDK to roll in. (flutter/engine#50575) 2024-02-13 6844906+zijiehe-google-com@users.noreply.github.com [Fuchsia] Run tests with test arguments (flutter/engine#50478) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change starts executing the suites with extra arguments, namely txt_tests, though the implementation does not limit to the suite.
Bug: flutter/flutter#140179
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.