This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Encode directly to command buffer for Metal. #49785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires #49780 since these touch most of the same code. |
jonahwilliams
commented
Jan 16, 2024
| MTLRenderPassDescriptor* desc_ = nil; | ||
| std::string label_; | ||
| bool is_metal_trace_active_ = false; |
chinmaygarde
approved these changes
Jan 17, 2024
| raster_message_loop_->PostTaskToAllWorkers([]() { | ||
| // See https://github.com/flutter/flutter/issues/65752 | ||
| // Intentionally opt out of QoS for raster task workloads. | ||
| [[NSThread currentThread] setThreadPriority:1.0]; |
There was a problem hiding this comment.
Get rid of the corresponding Foundation.h header import above?
| /// There should be no change to rendering if this caching was | ||
| /// absent. | ||
| /// | ||
| struct PassBindingsCache { |
There was a problem hiding this comment.
Move to its own TU and rename as PassBindingsCacheMTL.
| bool has_valid_pipeline_ = false; | ||
| bool has_label_ = false; | ||
| BufferView index_buffer_; | ||
| PrimitiveType primitive_type_; |
…ne into direct_encoding_metal
This reverts commit 8818531.
jonahwilliams
force-pushed
the
direct_encoding_metal
branch
from
a20fc81 to
3470e36
Compare
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 20, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 20, 2024
…141917) flutter/engine@53a2436...4d67f26 2024-01-20 jonahwilliams@google.com [Impeller] Encode directly to command buffer for Metal. (flutter/engine#49785) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#140804
Rather than using impeller::Command, the impeller::RenderPass records most state directly into the Vulkan command buffer. This should remove allocation/free overhead of the intermediary structures and make further improvements to the backend even easier.
This completely removes the background worker threads used for encoding, which should lower overall CPU usage without decreasing performance by much (though it may be a tad slower or a tad faster).