This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Refactors RBE support #49416
Merged
Refactors RBE support #49416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zanderso
force-pushed
the
rbe-macos-host
branch
4 times, most recently
from
938a94a to
9e50a1f
Compare
zanderso
force-pushed
the
rbe-macos-host
branch
2 times, most recently
from
06334fc to
079fff0
Compare
zanderso
force-pushed
the
rbe-macos-host
branch
from
079fff0 to
fc2ae0f
Compare
keyonghan
reviewed
Jan 9, 2024
jason-simmons
approved these changes
Jan 9, 2024
zanderso
added a commit
to flutter/buildroot
that referenced
this pull request
Jan 9, 2024
flutter/buildroot changes to support flutter/engine#49416
|
test-exempt: builds will fail if this is wrong |
zijiehe-google-com
pushed a commit
to zijiehe-google-com/engine
that referenced
this pull request
Jan 9, 2024
This PR refactors the RBE build and adds support for mac-hosted builds to use RBE. In particular, configurations files are downloaded from flutter-internal CIPD instead of being included in the repo. The download from CIPD is triggered by the presence of the `use_rbe` flag as a custom var in the `.gclient` file. This PR also turns on RBE for Linux and macOS builds that do not produce artifacts. flutter/buildroot#807
zanderso
added
the
revert
auto-submit
bot
removed
the
revert
auto-submit bot
pushed a commit
that referenced
this pull request
Jan 9, 2024
This reverts commit 555aa9b.
auto-submit bot
added a commit
that referenced
this pull request
Jan 9, 2024
Reverts #49416 Initiated by: zanderso This change reverts the following previous change: Original Description: This PR refactors the RBE build and adds support for mac-hosted builds to use RBE. In particular, configurations files are downloaded from flutter-internal CIPD instead of being included in the repo. The download from CIPD is triggered by the presence of the `use_rbe` flag as a custom var in the `.gclient` file. This PR also turns on RBE for Linux and macOS builds that do not produce artifacts. flutter/buildroot#807
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 10, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 10, 2024
…141224) flutter/engine@542fea9...941f268 2024-01-09 30870216+gaaclarke@users.noreply.github.com [Impeller] made sure to scale the blur radius by the effect transform (flutter/engine#49645) 2024-01-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Refactors RBE support" (flutter/engine#49654) 2024-01-09 zanderso@users.noreply.github.com Refactors RBE support (flutter/engine#49416) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
zanderso
added a commit
that referenced
this pull request
Jan 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the RBE build and adds support for mac-hosted builds to use RBE. In particular, configurations files are downloaded from flutter-internal CIPD instead of being included in the repo. The download from CIPD is triggered by the presence of the
use_rbeflag as a custom var in the.gclientfile.This PR also turns on RBE for Linux and macOS builds that do not produce artifacts.
flutter/buildroot#807