[Impeller] add explainer for Android CPU profiling. #48407

jonahwilliams · 2023-11-27T16:16:42Z

So you don't have to talk to me to figure out how to do this.

gaaclarke

LGTM I would prefer that this follows the same markdown guidelines we use for the webpage with respect to the column width (80 characters). There are also linters for md in vscode but I didn't notice anything.

gaaclarke · 2023-11-27T17:02:07Z

impeller/docs/android_cpu_profile.md

+
+2. Configure Gradle to not remove strip sources
+
+In the flutter project file android/app/build.gradle, add the following line under the android block:


Suggested change

In the flutter project file android/app/build.gradle, add the following line under the android block:

In the flutter project file `android/app/build.gradle`, add the following line under the `android` block:

gaaclarke · 2023-11-27T17:03:34Z

impeller/docs/android_cpu_profile.md

+    }
+```
+
+3. `flutter run` the app with the local engine flags.


Suggested change

3. `flutter run` the app with the local engine flags.

3. `flutter run` the app with the local engine flags (`--local-engine`, `--local-engine-host`, `--local-engine-src-path`)

gaaclarke · 2023-11-27T17:04:05Z

impeller/docs/android_cpu_profile.md

+3. `flutter run` the app with the local engine flags.
+4. Open Android Studio.
+
+You can create a new blank project if you don't have one already. You do not need to open the application project nor do you need to run the App through Android Studio. In fact, its much easier if you do not do those things.


Suggested change

You can create a new blank project if you don't have one already. You do not need to open the application project nor do you need to run the App through Android Studio. In fact, its much easier if you do not do those things.

You can create a new blank project if you don't have one already. You do not need to open the application project nor do you need to run the App through Android Studio. In fact, it's much easier if you do not do those things.

matanlurey · 2023-11-27T17:12:50Z

impeller/docs/android_cpu_profile.md

+
+# Android CPU Profiling
+
+Android devices have different performance characteristics than iOS devices, and I've found that CPU traces frequently reveal surprising performance issues, such as https://github.com/flutter/engine/pull/48303 . This document describes the steps to capture an equivalent [flame graph](https://cacm.acm.org/magazines/2016/6/202665-the-flame-graph/abstract) on your local Android device.


Scratch "I've found that", as it's reviewed/in our repo it doesn't need an "I found".

jonahwilliams · 2023-11-27T17:25:01Z

I installed a markdown formatter and it actually removed all of the line breaks. I don't think we need to enforce 80 col for something that we're not reading the source for 🤷‍♂️

…r/engine#48407)

…139099) flutter/engine@900ce09...0a098bd 2023-11-27 skia-flutter-autoroll@skia.org Manual roll Dart SDK from c9bdb5884670 to ef97fe2415fd (6 revisions) (flutter/engine#48414) 2023-11-27 jonahwilliams@google.com [Impeller] add explainer for Android CPU profiling. (flutter/engine#48407) 2023-11-27 jhy03261997@gmail.com [ios] Send " did gain focus" message from engine to framework (flutter/engine#48252) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#139099) flutter/engine@900ce09...0a098bd 2023-11-27 skia-flutter-autoroll@skia.org Manual roll Dart SDK from c9bdb5884670 to ef97fe2415fd (6 revisions) (flutter/engine#48414) 2023-11-27 jonahwilliams@google.com [Impeller] add explainer for Android CPU profiling. (flutter/engine#48407) 2023-11-27 jhy03261997@gmail.com [ios] Send " did gain focus" message from engine to framework (flutter/engine#48252) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

[Impeller] add explainer for Android CPU profiling.

e2d38f8

github-actions bot added the e: impeller label Nov 27, 2023

jonahwilliams requested review from matanlurey, gaaclarke and flar November 27, 2023 16:17

gaaclarke approved these changes Nov 27, 2023

View reviewed changes

matanlurey approved these changes Nov 27, 2023

View reviewed changes

jonahwilliams added 2 commits November 27, 2023 09:25

review.

94396a7

++

84939e5

jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 27, 2023

auto-submit bot merged commit deea2f4 into flutter:main Nov 27, 2023

jonahwilliams deleted the android_benchmarking branch November 27, 2023 20:46

engine-flutter-autoroll mentioned this pull request Nov 27, 2023

Roll Flutter Engine from 900ce09b08b2 to 0a098bd6f761 (3 revisions) flutter/flutter#139099

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 27, 2023

deea2f429 [Impeller] add explainer for Android CPU profiling. (flutte…

54789b0

…r/engine#48407)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Impeller] add explainer for Android CPU profiling. #48407

[Impeller] add explainer for Android CPU profiling. #48407

Uh oh!

jonahwilliams commented Nov 27, 2023

Uh oh!

gaaclarke left a comment

Uh oh!

gaaclarke Nov 27, 2023

Uh oh!

jonahwilliams Nov 27, 2023

Uh oh!

gaaclarke Nov 27, 2023

Uh oh!

jonahwilliams Nov 27, 2023

Uh oh!

gaaclarke Nov 27, 2023

Uh oh!

jonahwilliams Nov 27, 2023

Uh oh!

matanlurey Nov 27, 2023

Uh oh!

jonahwilliams Nov 27, 2023

Uh oh!

jonahwilliams commented Nov 27, 2023

Uh oh!

Uh oh!


		2. Configure Gradle to not remove strip sources

		In the flutter project file android/app/build.gradle, add the following line under the android block:

	In the flutter project file android/app/build.gradle, add the following line under the android block:
	In the flutter project file `android/app/build.gradle`, add the following line under the `android` block:

	3. `flutter run` the app with the local engine flags.
	3. `flutter run` the app with the local engine flags (`--local-engine`, `--local-engine-host`, `--local-engine-src-path`)

	You can create a new blank project if you don't have one already. You do not need to open the application project nor do you need to run the App through Android Studio. In fact, its much easier if you do not do those things.
	You can create a new blank project if you don't have one already. You do not need to open the application project nor do you need to run the App through Android Studio. In fact, it's much easier if you do not do those things.


		# Android CPU Profiling

		Android devices have different performance characteristics than iOS devices, and I've found that CPU traces frequently reveal surprising performance issues, such as https://github.com/flutter/engine/pull/48303 . This document describes the steps to capture an equivalent [flame graph](https://cacm.acm.org/magazines/2016/6/202665-the-flame-graph/abstract) on your local Android device.

[Impeller] add explainer for Android CPU profiling. #48407

[Impeller] add explainer for Android CPU profiling. #48407

Uh oh!

Conversation

jonahwilliams commented Nov 27, 2023

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonahwilliams commented Nov 27, 2023

Uh oh!

Uh oh!