This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
[ios] Send " did gain focus" message from engine to framework #48252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunhtai
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cc @vashworth |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 27, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 27, 2023
…139099) flutter/engine@900ce09...0a098bd 2023-11-27 skia-flutter-autoroll@skia.org Manual roll Dart SDK from c9bdb5884670 to ef97fe2415fd (6 revisions) (flutter/engine#48414) 2023-11-27 jonahwilliams@google.com [Impeller] add explainer for Android CPU profiling. (flutter/engine#48407) 2023-11-27 jhy03261997@gmail.com [ios] Send " did gain focus" message from engine to framework (flutter/engine#48252) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
caseycrogers
pushed a commit
to caseycrogers/flutter
that referenced
this pull request
Dec 29, 2023
…lutter#139099) flutter/engine@900ce09...0a098bd 2023-11-27 skia-flutter-autoroll@skia.org Manual roll Dart SDK from c9bdb5884670 to ef97fe2415fd (6 revisions) (flutter/engine#48414) 2023-11-27 jonahwilliams@google.com [Impeller] add explainer for Android CPU profiling. (flutter/engine#48407) 2023-11-27 jhy03261997@gmail.com [ios] Send " did gain focus" message from engine to framework (flutter/engine#48252) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: flutter/flutter#97747
framework pr :flutter/flutter#135771
android pr: #47114
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.