Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Missed linter argument comment violations #47310

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Missed linter argument comment violations #47310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82c36fb
Missed linter argument comment violations
gaaclarke Oct 25, 2023
b087a22
removed ci.yaml change
gaaclarke Oct 25, 2023
fc4685b
added mac violations too
gaaclarke Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions impeller/display_list/dl_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1390,7 +1390,7 @@ TEST_P(DisplayListTest, DrawVerticesSolidColorTrianglesWithoutIndices) {

auto vertices = flutter::DlVertices::Make(
flutter::DlVertexMode::kTriangles, 3, positions.data(),
/*texture_coorindates=*/nullptr, colors.data());
/*texture_coordinates=*/nullptr, colors.data());

flutter::DisplayListBuilder builder;
flutter::DlPaint paint;
Expand All @@ -1409,7 +1409,7 @@ TEST_P(DisplayListTest, DrawVerticesLinearGradientWithoutIndices) {

auto vertices = flutter::DlVertices::Make(
flutter::DlVertexMode::kTriangles, 3, positions.data(),
/*texture_coorindates=*/nullptr, /*colors=*/nullptr);
/*texture_coordinates=*/nullptr, /*colors=*/nullptr);

std::vector<flutter::DlColor> colors = {flutter::DlColor::kBlue(),
flutter::DlColor::kRed()};
Expand Down Expand Up @@ -1519,7 +1519,7 @@ TEST_P(DisplayListTest, DrawVerticesSolidColorTrianglesWithIndices) {

auto vertices = flutter::DlVertices::Make(
flutter::DlVertexMode::kTriangles, 6, positions.data(),
/*texture_coorindates=*/nullptr, /*colors=*/nullptr, 6, indices.data());
/*texture_coordinates=*/nullptr, /*colors=*/nullptr, 6, indices.data());

flutter::DisplayListBuilder builder;
flutter::DlPaint paint;
Expand All @@ -1540,7 +1540,7 @@ TEST_P(DisplayListTest, DrawVerticesPremultipliesColors) {

auto vertices = flutter::DlVertices::Make(
flutter::DlVertexMode::kTriangles, 6, positions.data(),
/*texture_coorindates=*/nullptr, colors.data(), 6, indices.data());
/*texture_coordinates=*/nullptr, colors.data(), 6, indices.data());

flutter::DisplayListBuilder builder;
flutter::DlPaint paint;
Expand Down Expand Up @@ -1668,7 +1668,7 @@ TEST_P(DisplayListTest, DrawVerticesBlendModes) {

auto vertices = flutter::DlVertices::Make(
flutter::DlVertexMode::kTriangles, 3, positions.data(),
/*texture_coorindates=*/nullptr, colors.data());
/*texture_coordinates=*/nullptr, colors.data());

flutter::DisplayListBuilder builder;
flutter::DlPaint paint;
Expand Down
2 changes: 1 addition & 1 deletion shell/platform/android/external_view_embedder/external_view_embedder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ void AndroidExternalViewEmbedder::SubmitFrame(

// Restore the clip context after exiting this method since it's changed
// below.
DlAutoCanvasRestore save(background_canvas, /*doSave=*/true);
DlAutoCanvasRestore save(background_canvas, /*do_save=*/true);

for (size_t i = 0; i < current_frame_view_count; i++) {
int64_t view_id = composition_order_[i];
Expand Down