This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Updated TextureSourceVK docs and deleted unused ivars #45123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
gaaclarke
commented
Aug 25, 2023
Comment on lines
-43
to
-45
| mutable RWMutex layout_mutex_; | ||
| mutable vk::ImageLayout layout_ IPLR_GUARDED_BY(layout_mutex_) = | ||
| vk::ImageLayout::eUndefined; |
gaaclarke
requested review from
chinmaygarde and
jonahwilliams
and removed request for
chinmaygarde
chinmaygarde
changed the title
| /// | ||
| /// The transition is from the layout stored via `SetLayoutWithoutEncoding` to | ||
| /// `barrier.new_layout`. | ||
| fml::Status SetLayout(const BarrierVK& barrier) const; |
There was a problem hiding this comment.
I had forgotten about fml::Status!
There was a problem hiding this comment.
Yea, this one was tricky since does "true" mean a transition happened or does "true" mean no error happened. I figured it's cleaner to just use the proper type. I wish we used it more often.
chinmaygarde
approved these changes
Aug 25, 2023
gaaclarke
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 25, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 25, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 25, 2023
…133355) flutter/engine@1471967...1ec7b89 2023-08-25 zanderso@users.noreply.github.com Remove --enable-software-rendering from iOS scenario tests (flutter/engine#45093) 2023-08-25 skia-flutter-autoroll@skia.org Roll Skia from 56bb647a49ac to 76672468e8d7 (3 revisions) (flutter/engine#45121) 2023-08-25 yatendraroria2001@gmail.com Fix: Complete Documentation for RasterStatus::kSkipAndRetry (flutter/engine#44880) 2023-08-25 30870216+gaaclarke@users.noreply.github.com [Impeller] Updated TextureSourceVK docs and deleted unused ivars (flutter/engine#45123) 2023-08-25 zanderso@users.noreply.github.com Revert "Fix global tests doing nothing." (flutter/engine#45125) 2023-08-25 skia-flutter-autoroll@skia.org Roll Skia from ba7c5258d2b4 to 56bb647a49ac (3 revisions) (flutter/engine#45118) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
added a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…tter#45123) Just some documentation and cleanup while i'm trying to get render pass recycling working. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some documentation and cleanup while i'm trying to get render pass recycling working.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.