This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix: Complete Documentation for RasterStatus::kSkipAndRetry #44880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Aug 24, 2023
jason-simmons
approved these changes
Aug 24, 2023
|
Hi, can you fix the linting errors as shown in the checks, so that this PR can land? |
yeah sure |
hey @dkwingsmt, I can't understand where's the linting error, If you check my file changes everything seems fine. |
dkwingsmt
reviewed
Aug 25, 2023
flow/compositor_context.h
Outdated
| @@ -40,9 +40,11 @@ enum class RasterStatus { | |||
| // This is currently used to wait for the thread merger to merge | |||
| // the raster and platform threads. | |||
| // | |||
| // Since the thread merger may be disabled, | |||
| // Since the thread merger may be disabled, the system will proceed | |||
There was a problem hiding this comment.
Suggested change
| // Since the thread merger may be disabled, the system will proceed | |
| // Since the thread merger may be disabled, the system will proceed |
dkwingsmt
reviewed
Aug 25, 2023
flow/compositor_context.h
Outdated
| @@ -40,9 +40,11 @@ enum class RasterStatus { | |||
| // This is currently used to wait for the thread merger to merge | |||
| // the raster and platform threads. | |||
| // | |||
| // Since the thread merger may be disabled, | |||
| // Since the thread merger may be disabled, the system will proceed | |||
| // with separate threads for rasterization and platform tasks, | |||
There was a problem hiding this comment.
Suggested change
| // with separate threads for rasterization and platform tasks, | |
| // with separate threads for rasterization and platform tasks, |
|
Two trailing spaces. (I'd suggest checking out if your code editor has an option to automatically remove trailing white spaces on saving.) |
omfg, that's such a silly error. sure i use vscode, i'll rn enable this functionality. thanks for the help |
dkwingsmt
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 25, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 25, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 25, 2023
…133355) flutter/engine@1471967...1ec7b89 2023-08-25 zanderso@users.noreply.github.com Remove --enable-software-rendering from iOS scenario tests (flutter/engine#45093) 2023-08-25 skia-flutter-autoroll@skia.org Roll Skia from 56bb647a49ac to 76672468e8d7 (3 revisions) (flutter/engine#45121) 2023-08-25 yatendraroria2001@gmail.com Fix: Complete Documentation for RasterStatus::kSkipAndRetry (flutter/engine#44880) 2023-08-25 30870216+gaaclarke@users.noreply.github.com [Impeller] Updated TextureSourceVK docs and deleted unused ivars (flutter/engine#45123) 2023-08-25 zanderso@users.noreply.github.com Revert "Fix global tests doing nothing." (flutter/engine#45125) 2023-08-25 skia-flutter-autoroll@skia.org Roll Skia from ba7c5258d2b4 to 56bb647a49ac (3 revisions) (flutter/engine#45118) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…44880) ## Description This PR completes the documentation for `RasterStatus::kSkipAndRetry` in the `compositor_context.h` file. The previous comment ended abruptly, leaving ambiguity regarding the behavior when the thread merger is disabled. ### Changes: - Added clarification on the behavior when the thread merger is disabled. - Explained the potential performance implications when threads are not merged. ## Related Issues flutter/flutter#131814 ## Tests No tests were added as this PR only involves documentation changes. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR completes the documentation for
RasterStatus::kSkipAndRetryin thecompositor_context.hfile. The previous comment ended abruptly, leaving ambiguity regarding the behavior when the thread merger is disabled.Changes:
Related Issues
flutter/flutter#131814
Tests
No tests were added as this PR only involves documentation changes.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.