[Impeller] Don't perform final layout transition on worker thread. #44510
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
changed the title
jonahwilliams
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/44510, due to - The status or check suite Mac mac_clang_tidy has failed. Please fix the issues identified (or deflake) before re-applying this label. |
jonahwilliams
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/44510, due to - The status or check suite Linux mac_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
matanlurey
added
the
autosubmit
…132238) flutter/engine@30e7780...b5b41ff 2023-08-09 ftsui@google.com Request GLES version 2 interface. (flutter/engine#44504) 2023-08-09 jonahwilliams@google.com [Impeller] Don't perform final layout transition on worker thread. (flutter/engine#44510) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#44510) This can lead to flutter/flutter#131717 because the raster thread may access the Queue while the worker thread is doing the final layout transition. Moving the final layout transition back to the raster thread should be fine, its really the presentation that we want to run in a background worker. Fixes flutter/flutter#131717
This can lead to flutter/flutter#131717 because the raster thread may access the Queue while the worker thread is doing the final layout transition. Moving the final layout transition back to the raster thread should be fine, its really the presentation that we want to run in a background worker.
Fixes flutter/flutter#131717