Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[CP][iOS][A11Y] fix hittest with non-SemanticsObject #44342

Merged
merged 1 commit into from
Aug 4, 2023
Merged

[CP][iOS][A11Y] fix hittest with non-SemanticsObject #44342

merged 1 commit into from
Aug 4, 2023

Conversation

cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Aug 3, 2023 •
edited
Loading

Cherry-pick #44014

Fixes flutter/flutter#131885

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[iOS][A11Y] fix hittest with non-SemanticsObject (flutter#44014)
b27bb91 
PlatformViewSemanticsContainer did not implement the nativeAccessibility method, leads to a nil object being returned. 

Fixes flutter/flutter#131014

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
@cyanglaz cyanglaz mentioned this pull request Aug 3, 2023
Closed
@cyanglaz
Copy link
Contributor Author

cyanglaz commented Aug 4, 2023

@stuartmorgan I'm on vacation starting today for a week. Could you help me land this cp? (I still plan to log on every day to check the status of this PR and do necessary fixes until it lands)

@stuartmorgan-g
Copy link
Contributor

Will do!

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 4, 2023
@auto-submit auto-submit bot merged commit b8332e3 into flutter:flutter-3.13-candidate.0 Aug 4, 2023
@cyanglaz cyanglaz deleted the cp_a11y_ios branch August 13, 2023 12:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

@hannah-hyj hannah-hyj Awaiting requested review from hannah-hyj

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cyanglaz @stuartmorgan-g @CaseyHillers