This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Added a doc page to point out important impeller benchmarks #44333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
force-pushed
the
impeller-benchmarks-doc
branch
from
f27502e to
aefe33e
Compare
chinmaygarde
reviewed
Aug 4, 2023
| @@ -0,0 +1,22 @@ | |||
| # Impeller Benchmarks | |||
There was a problem hiding this comment.
We should link to this doc from the main Impeller readme.
They should be valid until the devices in the device lab change or when the tests get replaced/renamed. The lookup keys are encoded in the url in an obfuscated way so it's hard to be 100% sure. |
gaaclarke
force-pushed
the
impeller-benchmarks-doc
branch
from
aefe33e to
ce7792e
Compare
zanderso
approved these changes
Aug 4, 2023
gaaclarke
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 4, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 4, 2023
…131948) flutter/engine@e9f80bf...a7bea86 2023-08-04 skia-flutter-autoroll@skia.org Roll Skia from 5eef2e2b94b4 to 85938bb68e75 (1 revision) (flutter/engine#44392) 2023-08-04 dnfield@google.com [Impeller] DlCanvas implementation wrapping Aiks canvas (flutter/engine#44248) 2023-08-04 30870216+gaaclarke@users.noreply.github.com [Impeller] Added a doc page to point out important impeller benchmarks (flutter/engine#44333) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
added a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
flutter#44333) My main goal here was to get a more clear picture of how the Vulkan implementation is performing in relation to the OpenGLES implementation. There is a lot of conventional wisdom about what benchmarks to look at that isn't documented anywhere. As we come to rely on benchmarks daily this should be updated. issue: flutter/flutter#131784 issue: flutter/flutter#131782 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My main goal here was to get a more clear picture of how the Vulkan implementation is performing in relation to the OpenGLES implementation. There is a lot of conventional wisdom about what benchmarks to look at that isn't documented anywhere. As we come to rely on benchmarks daily this should be updated.
issue: flutter/flutter#131784
issue: flutter/flutter#131782
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.