Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Add buffer-to-texture blit capability check; fix GL+VK playgrounds on macOS #41320

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

bdero
Copy link
Member

@bdero bdero commented Apr 19, 2023

GL/VK playgrounds that load image fixtures are currently broken on macOS.

@bdero bdero self-assigned this Apr 19, 2023
@bdero bdero changed the title [Impeller] Add buffer-to-texture capability check; fix GL+VK playgrounds on macOS [Impeller] Add buffer-to-texture blit capability check; fix GL+VK playgrounds on macOS Apr 19, 2023
@bdero bdero force-pushed the bdero/fix-playgrounds-glvk branch from 84fba90 to 50f7764 Compare April 19, 2023 03:48
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdero bdero force-pushed the bdero/fix-playgrounds-glvk branch from 50f7764 to b0c07af Compare April 19, 2023 03:50
@bdero bdero merged commit 609f9d5 into flutter:main Apr 19, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 19, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 19, 2023
…125097)

flutter/engine@8b7cdb0...609f9d5

2023-04-19 bdero@google.com [Impeller] Add buffer-to-texture blit capability check; fix GL+VK playgrounds on macOS (flutter/engine#41320)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants