This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Stop specifiying Macmini8,1 in ci builders, use inherited mac_model dimension #41223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
approved these changes
Apr 14, 2023
|
Can we also update the json files for the v2 builders? |
zanderso
approved these changes
Apr 14, 2023
|
Is this stale? |
I probably won't get to this this week. I'll merge this for now and let @dnfield follow up. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 2, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 2, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 2, 2023
…125909) flutter/engine@cd989fb...c4a2712 2023-05-02 leroux_bruno@yahoo.fr Web - Fix selection jump on Chrome for Android (flutter/engine#41202) 2023-05-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 84f3080c3165 to ea1fce8e0aa7 (1 revision) (flutter/engine#41672) 2023-05-02 magder@google.com Stop specifiying Macmini8,1 in ci builders, use inherited mac_model dimension (flutter/engine#41223) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #41219 all the .ci.yaml builders will run on either Macmini8,1 (x64) or Macmini9,1 (arm). Stop specifying
Macmini8,1on individual builders and let the specified architecture be the deciding factor.Reverts #41203