-
Notifications
You must be signed in to change notification settings - Fork 6k
Always set orientation preferences on iOS 16+ #40953
Conversation
} | ||
UIWindowSceneGeometryPreferencesIOS* preference = | ||
[[UIWindowSceneGeometryPreferencesIOS alloc] | ||
initWithInterfaceOrientations:_orientationPreferences]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
autorelease]
The old code also wasn't releasing the preference object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually recently caught this on the master branch in Instruments when I was looking at leaks, but I forgot to fix it there. I know it seems dumb but let's keep this matching #38230 with the leak since that's been baking awhile and we know it doesn't crash. This is a really tiny leak and I'll fix in master now 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im surprised that it doesn't have a windowSceneGeometryPreferencesIOSWithInterfaceOrientations:
method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really tiny leak and I'll fix in master now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@XilaiZhang did we move these web engine checks to post-submit? |
Looks like these targets have been removed from the .ci.yaml file on main branch, so they are pending. should be ready to merge |
Cherry-pick #38230 onto stable.
CP request at flutter/flutter#124208.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.