Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Gaussian blur: Add alpha mask specialization #40707

Merged
merged 4 commits into from
Mar 29, 2023

Conversation

bdero
Copy link
Member

@bdero bdero commented Mar 28, 2023

Adds a second bit to the gaussian blur specializations to get rid of the second texture sampling for the most common blur case.

@bdero bdero self-assigned this Mar 28, 2023
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdero bdero force-pushed the bdero/gaussian-blur-alphamask branch from e87f8ea to 04d9b71 Compare March 28, 2023 17:03
@bdero bdero force-pushed the bdero/gaussian-blur-alphamask branch from 2e8c17a to cfa9971 Compare March 28, 2023 18:50
@bdero bdero force-pushed the bdero/gaussian-blur-alphamask branch from cb70419 to 3c540c9 Compare March 28, 2023 23:34
@bdero bdero merged commit 5b8e024 into flutter:main Mar 29, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 29, 2023
zanderso pushed a commit to flutter/flutter that referenced this pull request Mar 29, 2023
…123664)

* 1d506dfd7 [Impeller] Allow metal shaders to compile through SPIR-V with openGL semantics. (flutter/engine#40616)

* 3287e2b36 [Impeller] support half precision uniforms and half precision samplers (flutter/engine#40590)

* 5c1c07fba Revert "Revert "Reland "Default the CanvasKit base URL to local artifacts. (#40293)" (#40470)" (#40700)" (flutter/engine#40717)

* 9e4cedc81 Forward stdout and stderr from dart2wasm when verbose. (flutter/engine#40731)

* 6941c1820 [Impeller] Allow toggling vulkan validation using a command line test flag. (flutter/engine#40728)

* 6ef595829 Roll buildroot to build CanvasKit for speed instead of code size (flutter/engine#40737)

* 5b8e02479 [Impeller] Gaussian blur: Add alpha mask specialization (flutter/engine#40707)

* 6852bea71 Roll Skia from 7311e9220faf to e3eeabb14e9c (4 revisions) (flutter/engine#40745)

* 235e42bea Add an option to malioc_diff.py to print a unified diff (flutter/engine#40732)

* 38e6d772f Roll Dart SDK from 1acd1e649fb7 to 69867ba60bb7 (2 revisions) (flutter/engine#40738)

* d81c4f2c7 [Impeller] migrate texture fill shaders to half precision. (flutter/engine#40735)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants