Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Started using bgr10_xr for opaque surfaces. #39727

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Started using bgr10_xr for opaque surfaces. #39727

merged 2 commits into from
Feb 21, 2023

Conversation

gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Feb 17, 2023 •
edited
Loading

fixes flutter/flutter#120641
integration tests: flutter/flutter#120914

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke marked this pull request as ready for review February 17, 2023 22:45
@gaaclarke gaaclarke requested a review from bdero February 17, 2023 22:57
bdero
bdero approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@bdero bdero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shell/platform/darwin/ios/ios_surface_metal_impeller.mm Outdated
namespace {
impeller::PixelFormat InferContextPixelFormat(impeller::PixelFormat pixel_format) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: InferOffscreenLayerPixelFormat?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 21, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 21, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 21, 2023

auto label is removed for flutter/engine, pr: 39727, due to - The status or check suite Mac mac_ios_engine_release has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Mac iOS Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac iOS clang-tidy has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 21, 2023
@auto-submit auto-submit bot merged commit 0fd15ee into flutter:main Feb 21, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine…
d246efc 
…#39727)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine…
fb52f31 
…#39727)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine…
f0b7066 
…#39727)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine…
71f2d0e 
…#39727)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine…
d1a3f9f 
…#39727)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine…
4669cf5 
…#39727)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine…
979239c 
…#39727)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine…
8e011b4 
…#39727)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine…
8178533 
…#39727)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine…
8ec28c8 
…#39727)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine…
f0a83db 
…#39727)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine…
5b5ec81 
…#39727)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine…
4141d5d 
…#39727)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine…
58bc584 
…#39727)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine…
6951ea9 
…#39727)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine…
ac02291 
…#39727)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine…
68baed7 
…#39727)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine…
d3b66fc 
…#39727)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine…
9ec899b 
…#39727)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine…
9740887 
…#39727)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine…
04871e8 
…#39727)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine…
a0e14ab 
…#39727)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine…
4a04918 
…#39727)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine…
22878c0 
…#39727)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
Roll Flutter Engine from 3aa112c75ccb to 137caa761540 (20 revisions) (#…
fede6d1 
…121286)

* 0fd15eece Started using bgr10_xr for opaque surfaces. (flutter/engine#39727)

* f0e5c08f7 [platform_view] fix overlapping platform view not touchable (flutter/engine#39527)

* 03b5998b4 Roll Fuchsia Mac SDK from 25mb67G0L_sZ_OQCC... to dj-2XkYHvZUsqlZTc... (flutter/engine#39782)

* 2e5b1bf04 Updated the wide-gamut constant and added a unit test for it. (flutter/engine#39776)

* 1ce93ca0a Roll Dart SDK from 0db7573c6b70 to c9a4fd7fd7fa (1 revision) (flutter/engine#39783)

* 8368fb5b6 Roll Dart SDK from c9a4fd7fd7fa to 5003b952affb (1 revision) (flutter/engine#39787)

* ee5ea205b Roll Dart SDK from 5003b952affb to 6f5df63655ad (1 revision) (flutter/engine#39790)

* d9be356a8 Roll Fuchsia Mac SDK from dj-2XkYHvZUsqlZTc... to cGa3bk2BmrHL_waB8... (flutter/engine#39791)

* 50af61302 [web] Add `dart:js_interop` to BUILD.gn. (flutter/engine#39792)

* eb5e5624d [common] Use FML macro to prevent copy/assignment (flutter/engine#39786)

* 6acfddc78 Add more log when receiving semantics node not part of update (flutter/engine#39777)

* 336e7ce63 Roll Skia from 22b594afb4d3 to 78bad646fe78 (24 revisions) (flutter/engine#39793)

* e65391f8b [Impeller] Add root dockspace to playgrounds (flutter/engine#39789)

* 3848f6429 [Impeller] ensure glyph type contributes to FontGlyphPair hash/eq (flutter/engine#39794)

* cb1ef6f08 Roll Skia from 78bad646fe78 to 335cabcf8b99 (2 revisions) (flutter/engine#39795)

* ac6129db2 made opaque wide gamut images take up 32 bits per pixel (flutter/engine#39691)

* c74a4bc67 save/restore around clipping the (potentially cached) frame canvas (flutter/engine#39797)

* ed3f15d94 [Embedder API] Add CODEOWNERS (flutter/engine#39784)

* 1a3bddcc1 Fix a race in ShellTest.PushBackdropFilterToVisitedPlatformViews (flutter/engine#39798)

* 137caa761 Roll Dart SDK from 6f5df63655ad to 602941be8007 (2 revisions) (flutter/engine#39800)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdero bdero bdero approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Impeller] Optimize the opaque surfaces to use MTLPixelFormatBGR10_XR (32bpp).
2 participants
@gaaclarke @bdero