Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Migrate @FfiNative to @Native #39034

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Migrate @FfiNative to @Native #39034

merged 1 commit into from
Jan 24, 2023

Conversation

dcharkes
Copy link
Contributor

Migrates @FfiNative to @Native.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@dcharkes dcharkes force-pushed the migrate-ffi-natives branch from 119599e to b5e5e0a Compare January 24, 2023 08:42
@dcharkes dcharkes force-pushed the migrate-ffi-natives branch from b5e5e0a to 68b52b8 Compare January 24, 2023 10:43
Copy link
Member

@mkustermann mkustermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcharkes dcharkes added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2023
@auto-submit auto-submit bot merged commit 7f38d0d into main Jan 24, 2023
@dcharkes
Copy link
Contributor Author

Thanks @mkustermann !

@dcharkes dcharkes deleted the migrate-ffi-natives branch January 24, 2023 11:40
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 24, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 24, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 24, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 24, 2023
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 24, 2023
…119081)

* 22084db7a Remove unnecessary null checks in doc snippet (flutter/engine#39071)

* f91890636 Roll Skia from f6a5c806294d to 1ccf2093cfa9 (2 revisions) (flutter/engine#39028)

* f02a70492 Roll Fuchsia Mac SDK from rQtxqj3gePeR-nTLv... to HxpwvvbQdk54L6_8q... (flutter/engine#39075)

* 42eec6280 [Impeller] uniform offsets account for size (flutter/engine#39077)

* b6a348a82 Ability to disable browser context menu (flutter/engine#38682)

* 1b51696eb Roll Skia from 1ccf2093cfa9 to 0328e12ab195 (59 revisions) (flutter/engine#39078)

* d83a705ef [embedder] Fix getting vkGetInstanceProcAddr (flutter/engine#39051)

* 973b01c40 Fix doc analyzer breakage (flutter/engine#39082)

* 55e9eafab Roll Dart SDK from 107a1280a61f to d1a0e860679e (2 revisions) (flutter/engine#39084)

* fa07c546c Roll Skia from 0328e12ab195 to 50d78376d30c (3 revisions) (flutter/engine#39086)

* 17abf1a9e Roll Fuchsia Linux SDK from GLRbnjiO5SbZKX-Us... to dWbkAZchFHtZE9Wt_... (flutter/engine#39087)

* 5c46d75f7 Roll Skia from 50d78376d30c to 90fda2e72314 (4 revisions) (flutter/engine#39089)

* 5b4e331a6 Add mmap dependency to flutter_frontend_server (flutter/engine#39090)

* 7f38d0d4f Migrate `@FfiNative` to `@Native` (flutter/engine#39034)

* 71ee5f19b Remove superfluous words from comments (flutter/engine#39068)
ricardoamador pushed a commit to ricardoamador/engine that referenced this pull request Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants