-
Notifications
You must be signed in to change notification settings - Fork 6k
Revert "[macOS] Refactor rendering infrastructure" #38332
Conversation
This reverts commit 6cd8561.
@cbracken can you help with the reland to prevent future breakages? Issue seems to be with differences in how the compilers are configured. |
Yep - thanks for catching this! |
@CaseyHillers Can you attach the compiler error output to help with the fix? |
@cbracken I've gone ahead and added the unique errors to the description. Some of its been redacted, but I think I got the main errors included. |
Looks like a missing std::vector import? I am a bit curious why it compiles at all. Precompiled headers seem to be disabled in buildroot. |
Thanks. Probably faster for me to quick iterate on the internal roll patch (cl/495619470) to get it to compiling state rather than iterate through the chain of rollers. @knopp If you want to put together a reland patch I can add the changes or just paste the patch and you can apply it and reland. |
auto label is removed for flutter/engine, pr: 38332, due to - The status or check suite Linux License has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Does your internal build use different libcxx version? The one included in third_party/libcxx includes vector implicitly (functional -> boyer_moore_searcher -> vector), that's why I missed it. |
@cbracken has a one line fix he's going to send |
Reverts #37789
Google internal bug at b/262764490
This is causing breakages as the std calls aren't explicitly called. Relanding requires ensuring things like
#include <vector
are in the culprit files.Sample of errors: