This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Web] Synthesize modifiers key up based on known logical key #37280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bleroux
force-pushed
the
web_synthesize_modifier_key_up_using_known_logical_key
branch
from
91f60e7 to
01fb791
Compare
dkwingsmt
reviewed
Nov 7, 2022
| @@ -635,12 +635,14 @@ class KeyboardConverter { | |||
|
|
|||
| // Synthesize an up event for left key if pressed | |||
There was a problem hiding this comment.
It seems we can remove the logicalRight in the parameter list.
dkwingsmt
reviewed
Nov 7, 2022
| _MouseEventContext(), | ||
| _TouchEventContext(), | ||
| ], | ||
| 'should synthesize modifier keys up event using known pressed logical key', |
There was a problem hiding this comment.
Suggested change
| 'should synthesize modifier keys up event using known pressed logical key', | |
| 'should synthesize modifier keys up event for AltGraph', |
bleroux
force-pushed
the
web_synthesize_modifier_key_up_using_known_logical_key
branch
from
01fb791 to
86eea35
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 7, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 7, 2022
…114847) * 3d9f48580 [Embedder API] Introduce new semantics update callback (flutter/engine#37129) * b673ce3c3 Roll Skia from da9fad017aee to dec7a930c0b7 (10 revisions) (flutter/engine#37390) * df602070a [Web] Synthesize modifiers key up based on known logical key (flutter/engine#37280)
bleroux
deleted the
web_synthesize_modifier_key_up_using_known_logical_key
branch
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Nov 9, 2022
…#37280) Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
…#37280) Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#114847) * 3d9f48580 [Embedder API] Introduce new semantics update callback (flutter/engine#37129) * b673ce3c3 Roll Skia from da9fad017aee to dec7a930c0b7 (10 revisions) (flutter/engine#37390) * df602070a [Web] Synthesize modifiers key up based on known logical key (flutter/engine#37280)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#114847) * 3d9f48580 [Embedder API] Introduce new semantics update callback (flutter/engine#37129) * b673ce3c3 Roll Skia from da9fad017aee to dec7a930c0b7 (10 revisions) (flutter/engine#37390) * df602070a [Web] Synthesize modifiers key up based on known logical key (flutter/engine#37280)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since #36724, modifier keys up and down events are synthesized on pointer events. This PR fixes an issue related to the logical key used to synthesize modifier keys up events. In some particular cases, a modifier key can be associated to several logical keys (for instance, the alt right physical key could be associated to
AltRightorAltGrlogical keys). This PR updates the modifier up event synthesization logic to synthesize up events using the logical key used for the down event.This PR also contains the updated file
lib/web_ui/lib/src/engine/key_map.g.dart(generated from the changes included in flutter/flutter#114499).Related Issue
Fixes flutter/flutter#114504
Tests
Adds 1 test