Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[reland] Canvaskit get googlefont data #35646

Merged
merged 44 commits into from
Aug 24, 2022
Merged

[reland] Canvaskit get googlefont data #35646

merged 44 commits into from
Aug 24, 2022

Conversation

harryterkelsen
Copy link
Contributor

Generates fallback font data by downloading and analyzing all known "Noto Sans" fonts.

Fixes flutter/flutter#101738

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@harryterkelsen
WIP font data script
efa7c61
@harryterkelsen
wip
5df1ee4
@harryterkelsen
WIP
377703c
@harryterkelsen
wip
2ff37e5
@harryterkelsen
Merge branch 'main' into canvaskit-get-googlefont-data
c7e7b54
@harryterkelsen
WIP
a9ffa81
@harryterkelsen
Merge main
dc119fe
@harryterkelsen
Merge branch 'main' into canvaskit-get-googlefont-data
d68dade
@harryterkelsen
Remove family count and touch up tests
62db0c0
@harryterkelsen
Merge branch 'main' into canvaskit-get-googlefont-data
9da5993
@harryterkelsen
Undo spurious changes
f2edc35
@harryterkelsen
Update license
493fa6d
@harryterkelsen
Merge branch 'main' into canvaskit-get-googlefont-data
d5e28f8
@harryterkelsen
Merge branch 'main' into canvaskit-get-googlefont-data
0293256
@harryterkelsen
Merge branch 'main' into canvaskit-get-googlefont-data
88f6683
@harryterkelsen
WIP
0255cd8
@harryterkelsen
WIP
d448215
@harryterkelsen
Use flat range list and binary search
e385094
@harryterkelsen
Update README
4275e7c
@harryterkelsen
Merge branch 'main' into canvaskit-get-googlefont-data
c4c5829
@harryterkelsen
Add edge cases for when the range containing the unit is either the
3ac2c06 
first or last
@harryterkelsen
Fix edge cases in binary search where first or last range contains the
2724489 
unit
@harryterkelsen
Merge branch 'main' into canvaskit-get-googlefont-data
4c434c0
@harryterkelsen
Retry tests
9744831
@harryterkelsen
Fix generated file
a6b6567
@harryterkelsen
Fix generated file
a6a33b1
@harryterkelsen
Fix generated fonts
facbe5d
@harryterkelsen
Fix generation
56970e6
@harryterkelsen
Generate font data
19df75b
@harryterkelsen
Analysis warnings
cfd7b45
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Aug 23, 2022
@harryterkelsen harryterkelsen requested a review from yjbanov August 24, 2022 19:58
yjbanov
yjbanov reviewed Aug 24, 2022
View reviewed changes
yjbanov
yjbanov approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harryterkelsen harryterkelsen merged commit 7406fd8 into flutter:main Aug 24, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 25, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 25, 2022
@engine-flutter-autoroll
7406fd818 [reland] Canvaskit get googlefont data (flutter/engine#35646)
bc6a69e
GaryQian pushed a commit to GaryQian/engine that referenced this pull request Aug 25, 2022
@GaryQian
[reland] Canvaskit get googlefont data (flutter#35646)
f393d48
@yjbanov yjbanov mentioned this pull request Oct 22, 2022
Closed
@harryterkelsen harryterkelsen mentioned this pull request Oct 26, 2022
Closed
@mdebbar mdebbar mentioned this pull request Jan 11, 2023
Merged
@bleroux bleroux mentioned this pull request Feb 22, 2023
Closed
@ditman ditman mentioned this pull request Jun 22, 2023
Open
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees
No one assigned
Labels
platform-web Code specifically for the web engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Web canvaskit] Does not render Thai Text on Edge browser
2 participants
@harryterkelsen @yjbanov