Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix release builds on iOS #344

Merged
merged 1 commit into from
Jul 29, 2015
Merged

Fix release builds on iOS #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/config/compiler/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1113,7 +1113,7 @@ if (is_win) {
}
}

if (is_mac) {
if (is_mac || is_ios) {
if (symbol_level == 2) {
# Mac dead code stripping requires symbols.
common_optimize_on_ldflags += [ "-Wl,-dead_strip" ]
Expand Down
7 changes: 5 additions & 2 deletions sky/engine/bindings/builtin_natives.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,10 @@
#endif

#if __APPLE__
#include <syslog.h>
extern "C" {
// Cannot import the syslog.h header directly because of macro collision
extern void syslog(int, const char *, ...);
}
#endif

namespace blink {
Expand Down Expand Up @@ -175,7 +178,7 @@ void Logger_PrintString(Dart_NativeArguments args) {
// message is discoverable when running on an unrooted device.
__android_log_print(ANDROID_LOG_INFO, "sky", "%.*s", length, chars);
#elif __APPLE__
syslog(LOG_INFO, "%.*s", (int)length, chars);
syslog(6 /* Informational */, "%.*s", (int)length, chars);
#endif
}
}
Expand Down