This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use darwin rather than mac for dart_sdk artifacts. #33821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the platforms except mac use the platform name but mac uses darwin instead.
godofredoc
requested review from
christopherfujino,
zanderso and
dnfield
and removed request for
christopherfujino
chinmaygarde
approved these changes
Jun 4, 2022
godofredoc
added
the
waiting for tree to go green
zanderso
approved these changes
Jun 4, 2022
| @@ -107,6 +107,11 @@ if (build_engine_artifacts && flutter_prebuilt_dart_sdk) { | |||
| zip_bundle("dart_sdk_archive") { | |||
| deps = [] | |||
| output = "dart-sdk-$full_target_platform_name.zip" | |||
| if (is_mac) { | |||
| # Mac artifacts sometimes use mac and sometimes darwin. Standardizing the | |||
There was a problem hiding this comment.
This comment is more of a TODO. Is there an issue to point at for it?
There was a problem hiding this comment.
Done: created flutter/flutter#105351 to track.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2022
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the platforms except mac use the platform name but mac uses darwin
instead.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.