This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
[fuchsia] Set blending mode on flatland images #30890
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbreng
approved these changes
Jan 15, 2022
akbiggs
approved these changes
Jan 15, 2022
fe3287b to
e3d01f3
Compare
Contributor
Author
|
Bots show a build error that suggest fuchsia SDK roll hasn't happened. This is compiling and passing for me locally though. Is there any other roll that I should wait for? |
Contributor
Author
|
FYI these changed went to fuchsia tree >1 month ago https://fuchsia-review.googlesource.com/c/fuchsia/+/614924. |
e3d01f3 to
c6e5c98
Compare
c6e5c98 to
04087cb
Compare
Contributor
Author
|
It looks like my fork needed an update and merge. Should be good now! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 18, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 18, 2022
godofredoc
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 19, 2022
* 5d39fbc Roll Fuchsia Mac SDK from KyHYWmWPl... to HONostNiI... (flutter/engine#30906) * 31abc8f [fuchsia] Set blending mode on flatland images (flutter/engine#30890) * 8c838dc Roll Skia from 7022d7456730 to 466df1e697fd (1 revision) (flutter/engine#30907) * 00a45c3 Roll Dart SDK from 4a4f34a69fc1 to 72aa28127bbf (9 revisions) (flutter/engine#30908) * ae34643 Roll Skia from 466df1e697fd to 9f231c330962 (2 revisions) (flutter/engine#30910) * 7a33b4b [fuchsia] Update Vulkan header version to 1.2.198. (flutter/engine#30770)
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
* 5d39fbc Roll Fuchsia Mac SDK from KyHYWmWPl... to HONostNiI... (flutter/engine#30906) * 31abc8f [fuchsia] Set blending mode on flatland images (flutter/engine#30890) * 8c838dc Roll Skia from 7022d7456730 to 466df1e697fd (1 revision) (flutter/engine#30907) * 00a45c3 Roll Dart SDK from 4a4f34a69fc1 to 72aa28127bbf (9 revisions) (flutter/engine#30908) * ae34643 Roll Skia from 466df1e697fd to 9f231c330962 (2 revisions) (flutter/engine#30910) * 7a33b4b [fuchsia] Update Vulkan header version to 1.2.198. (flutter/engine#30770)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
platform-fuchsia
waiting for tree to go green
This PR is approved and tested, but waiting for the tree to be green to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL makes use of the newly added blending mode api for flatland.
Bug: 91557