Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Update //third_party/glfw from Aug 2016 to Jan 2019 (revision 78e6a006) #30609

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Update //third_party/glfw from Aug 2016 to Jan 2019 (revision 78e6a006) #30609

merged 1 commit into from
Jan 6, 2022

Conversation

eggfly
Copy link
Member

@eggfly eggfly commented Dec 31, 2021 •
edited
Loading

Issue ID:

It updates the GLFS to a 2019 version, some source code in GLFW had been renamed. So it also relies on this change in buildroot:

Because the lateset version contains a change need macOS 10.12, the min supported macOS version of flutter is 10.11:

#if MAC_OS_X_VERSION_MAX_ALLOWED >= 101200
    if ([window->ns.object respondsToSelector:@selector(setTabbingMode:)])
        [window->ns.object setTabbingMode:NSWindowTabbingModeDisallowed];
#endif

Or can I change the latest code in https://fuchsia.googlesource.com/third_party/glfw/, and how can I contribute code to it?

TODO: DEPS should change to the latest buildroot revision after that change merged.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@eggfly eggfly force-pushed the update_glfw branch 2 times, most recently from ad71c8f to 50fe8cd Compare December 31, 2021 07:44
@eggfly eggfly changed the title Update GLFW to revision 78e6a006 Update //thirdparty/GLFW from Aug 2016 to Jan 2019 (revision 78e6a006) Dec 31, 2021
@eggfly eggfly changed the title Update //thirdparty/GLFW from Aug 2016 to Jan 2019 (revision 78e6a006) Update //thirdparty/glfw from Aug 2016 to Jan 2019 (revision 78e6a006) Dec 31, 2021
@eggfly eggfly changed the title Update //thirdparty/glfw from Aug 2016 to Jan 2019 (revision 78e6a006) Update //third_party/glfw from Aug 2016 to Jan 2019 (revision 78e6a006) Dec 31, 2021
@eggfly eggfly mentioned this pull request Dec 31, 2021
Merged
8 tasks
@eggfly eggfly requested review from dnfield, chinmaygarde and akbiggs and removed request for dnfield December 31, 2021 09:19
@bdero
Copy link
Member

bdero commented Jan 5, 2022 •
edited
Loading

This is stuck behind #30679 at the moment. Should be good to go once that lands and this is rebased.

@eggfly
Copy link
Member Author

eggfly commented Jan 5, 2022 •
edited
Loading

This is stuck behind #30679 at the moment. Should be good to go once that lands and this is rebased.

Yes. I will wait for a moment. cc @godofredoc

@godofredoc
Copy link
Contributor

This is stuck behind #30679 at the moment. Should be good to go once that lands and this is rebased.

Yes. I will wait for a moment. cc @godofredoc

#30679 has landed please rebase.

@eggfly eggfly added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jan 6, 2022
@fluttergithubbot fluttergithubbot merged commit ed6868f into flutter:main Jan 6, 2022
@eggfly eggfly deleted the update_glfw branch January 6, 2022 04:47
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 6, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 6, 2022
@engine-flutter-autoroll
ed6868f Update //third_party/glfw from Aug 2016 to Jan 2019 (revision…
47d42f9 
… 78e6a006) (flutter/engine#30609)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 7, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 7, 2022
@engine-flutter-autoroll
ed6868f Update //third_party/glfw from Aug 2016 to Jan 2019 (revision…
9535026 
… 78e6a006) (flutter/engine#30609)
zanderso pushed a commit to flutter/flutter that referenced this pull request Jan 7, 2022
@engine-flutter-autoroll
Roll Engine from 8498779 to 594238c (22 revisions) (#96268)
3e5ddff 
* 1f60bfc Fix missing shcore.dll error on Windows 7 (flutter/engine#30699)

* 4c30367 Roll Fuchsia Mac SDK from G04Sc3__F... to WjrtT4DAB... (flutter/engine#30700)

* 2bf6b01 Migrate keyboard_key_handler_unittests to keyboard_win32_unittests (flutter/engine#30615)

* ed6868f Update //third_party/glfw from Aug 2016 to Jan 2019 (revision 78e6a006) (flutter/engine#30609)

* 7fae72a Roll Skia from 88c5af7ecd72 to 8e6b60f27da3 (3 revisions) (flutter/engine#30703)

* b01a5a9 Roll Fuchsia Mac SDK from WjrtT4DAB... to fSRFvvC1c... (flutter/engine#30705)

* 63f9190 Roll Skia from 8e6b60f27da3 to f5853ff6525b (1 revision) (flutter/engine#30706)

* 7467eac Roll Skia from f5853ff6525b to db2b8eb98f14 (1 revision) (flutter/engine#30708)

* 936c3a0 Roll Skia from db2b8eb98f14 to 426f7b5ad606 (2 revisions) (flutter/engine#30710)

* 9524ec8 Roll Skia from 426f7b5ad606 to a5d4541ae556 (3 revisions) (flutter/engine#30712)

* e8bb686 Roll Skia from a5d4541ae556 to 96e4053be7a5 (3 revisions) (flutter/engine#30714)

* d301340 Roll Skia from 96e4053be7a5 to ce49ff6520fa (4 revisions) (flutter/engine#30715)

* 38a007d Roll Dart SDK from f59531cc2973 to 5f2c54513b7d (13 revisions) (flutter/engine#30716)

* 305dcd5 Roll Skia from ce49ff6520fa to 73657689b6cb (5 revisions) (flutter/engine#30718)

* d930dce [web] allow customizing Ahem URL using FontManifest.json (flutter/engine#30719)

* a0bbfeb Roll Skia from 73657689b6cb to 72412a86725a (3 revisions) (flutter/engine#30721)

* d53b3c2 Fix aot builds in the dart_runner for fuchsia (flutter/engine#30722)

* 56816a0 Roll Skia from 72412a86725a to 2f3891bf76f3 (1 revision) (flutter/engine#30723)

* 496e055 Roll Dart SDK from 5f2c54513b7d to 8a8fb0972646 (1 revision) (flutter/engine#30725)

* 685d220 Bump Robolectric to 4.7.3 (flutter/engine#30437)

* f8a8276 Roll Fuchsia Mac SDK from fSRFvvC1c... to cSwk_StnQ... (flutter/engine#30727)

* 594238c Revert Dart SDK to f59531cc2973 (flutter/engine#30729)
JsouLiang pushed a commit to JsouLiang/engine that referenced this pull request Jan 14, 2022
@eggfly @JsouLiang
Update //third_party/glfw from Aug 2016 to Jan 2019 (revision 78e6a00…
c1eb336 
…6) (flutter#30609)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@dnfield dnfield Awaiting requested review from dnfield

@akbiggs akbiggs Awaiting requested review from akbiggs

Assignees
No one assigned
Labels
waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eggfly @bdero @godofredoc @chinmaygarde @fluttergithubbot