Fix dead key crashes on Win32

[dkwingsmt]

This PR fixes the crash caused by pressing dead keys on Win32.

It was not tested out because the MapVk function does not work the same in unit tests. Another dependency injection has been added.

Fixes flutter/flutter#88108.

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
• I listed at least one issue that this PR fixes in the description above.
• I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
  writing and running engine tests.
• I updated/added relevant documentation (doc comments with ///).
• I signed the CLA.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[gspencergoog]

[gspencergoog]

Love the name. :-)

[marcoprodata]

The problem persist, need to open another issue?

[dkwingsmt]

@marcoprodata It takes a few hours for the change to be rolled into flutter/flutter. Can you try again?

[marcoprodata]

Yes, tomorrow i will try again, thanks for your attention

[marcoprodata]

@dkwingsmt the problem persist, updated and the winapp crash with accents

Launching lib\main.dart on Windows in debug mode...
Connecting to VM Service at ws://127.0.0.1:59050/B6Bz_A_vuMw=/ws
Unable to parse JSON message:
The document is empty.

════════ Exception caught by services library ══════════════════════════════════
The following RangeError was thrown during a platform message callback:
Invalid value: Not in inclusive range 0..1114111: 2147483828

When the exception was thrown, this was the stack
#0 new String.fromCharCode (dart:core-patch/string_patch.dart:45:5)
#1 new RawKeyEvent.fromMessage
#2 KeyEventManager.handleRawKeyMessage
#3 BasicMessageChannel.setMessageHandler.
#4 BasicMessageChannel.setMessageHandler.
#5 _DefaultBinaryMessenger.setMessageHandler.
#6 _DefaultBinaryMessenger.setMessageHandler.
#7 _invoke2. (dart:ui/hooks.dart:205:15)
#11 _invoke2 (dart:ui/hooks.dart:204:10)
#12 _ChannelCallbackRecord.invoke (dart:ui/channel_buffers.dart:42:5)
#13 _Channel.push (dart:ui/channel_buffers.dart:132:31)
#14 ChannelBuffers.push (dart:ui/channel_buffers.dart:329:17)
#15 PlatformDispatcher._dispatchPlatformMessage (dart:ui/platform_dispatcher.dart:544:22)
#16 _dispatchPlatformMessage (dart:ui/hooks.dart:92:31)
(elided 3 frames from dart:async)
════════════════════════════════════════════════════════════════════════════════
Lost connection to device.
Exited (sigterm)

[dkwingsmt]

Is it still the same reproduction step, Portuguese keyboard and press ê?

On Mon, Aug 16, 2021 at 5:08 AM marcoprodata ***@***.***> wrote: @dkwingsmt <https://github.com/dkwingsmt> the problem persist, updated and the winapp crash with accents Launching lib\main.dart on Windows in debug mode... Connecting to VM Service at ws://127.0.0.1:59050/B6Bz_A_vuMw=/ws Unable to parse JSON message: The document is empty. ════════ Exception caught by services library ══════════════════════════════════ The following RangeError was thrown during a platform message callback: Invalid value: Not in inclusive range 0..1114111: 2147483828 When the exception was thrown, this was the stack #0 new String.fromCharCode (dart:core-patch/string_patch.dart:45:5) #1 <#1> new RawKeyEvent.fromMessage #2 <#2> KeyEventManager.handleRawKeyMessage #3 <#3> BasicMessageChannel.setMessageHandler. #4 <#4> BasicMessageChannel.setMessageHandler. #5 _DefaultBinaryMessenger.setMessageHandler. #6 <#6> _DefaultBinaryMessenger.setMessageHandler. #7 <#7> _invoke2. (dart:ui/hooks.dart:205:15) #11 <#11> _invoke2 (dart:ui/hooks.dart:204:10) #12 <#12> _ChannelCallbackRecord.invoke (dart:ui/channel_buffers.dart:42:5) #13 <#13> _Channel.push (dart:ui/channel_buffers.dart:132:31) #14 <#14> ChannelBuffers.push (dart:ui/channel_buffers.dart:329:17) #15 <#15> PlatformDispatcher._dispatchPlatformMessage (dart:ui/platform_dispatcher.dart:544:22) #16 <#16> _dispatchPlatformMessage (dart:ui/hooks.dart:92:31) (elided 3 frames from dart:async) ════════════════════════════════════════════════════════════════════════════════ Lost connection to device. Exited (sigterm) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#28047 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMFZ4FAEEFQFJPDTPRIIRLT5D5TDANCNFSM5CB52DSQ> .

-- 牟瞳 清华大学电子工程系 微电子与纳电子学系 182 1023 4773 北京市海淀区清华园紫荆学生公寓1号楼527B 100084 MU Tong Department of Electronic Engineering Department of Microelectronics and Nanoelectronics Tsinghua University +86 182 1023 4773 Room 527B, Building No.1, Zijing Apartment, Tsinghua University, Haidian District, Beijing China 100084

[marcoprodata]

Yes, any accent, ãõéáó, after press the accent key the error was launched in the console and the winapp crash

[eduardo-cervantes]

I've been following this issue for some time, and I still have the application closing when using accent.
Same mistake commented above by @marcoprodata.

======== Exception caught by services library ======== 
The following RangeError was thrown during a platform message callback:
Invalid value: Not in inclusive range 0..1114111: 2147483687

[marcoprodata]

@dkwingsmt Thanks for your attention, now the winapp dont crash and accents works correctly, the only thing that remain is when press twice dead keys, reported reported in PR by knopp