This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Added assertion up to cv99 for FontFeature.characterVariant #27745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b30a8c3
to
beb88af
Compare
This is great, it would allow OTF fonts with specific variants to be super useful and would also allow the developer not having to create workarounds for custom symbols that aren't unicode. |
d6d6388
to
d3792f4
Compare
Hixie
approved these changes
Aug 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't have noticed except for really wanting to use a very specific font 😹 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 3, 2021
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 3, 2021
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
…27745) * Added assertion up to cv99 for FontFeature.characterVariant * Added FontFeature.characterVariant(99) test
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Apr 21, 2022
…27745) * Added assertion up to cv99 for FontFeature.characterVariant * Added FontFeature.characterVariant(99) test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the assertion in
factory FontFeature.characterVaraint
from up to20
to up to99
in order to support additional Character VariantsYou can check the OpenType docs to confirm the character variants go from cv01 to cv99
https://docs.microsoft.com/en-us/typography/opentype/spec/features_ae#cv01-cv99
Pre-launch Checklist
writing and running engine tests.
///
).