This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Roll Dart SDK from c696ecf5a8a0 to bb9d96ffbafa (1 revision) #26370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://dart.googlesource.com/sdk.git/+log/c696ecf5a8a0..bb9d96ffbafa 2021-05-24 dart-luci-ci-builder@dart-ci.iam.gserviceaccount.com Version 2.14.0-146.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC dart-vm-team@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
skia-flutter-autoroll
force-pushed
the
dart-sdk-flutter-engine-e6493f56-3cbf-4118-bb65-090a1bad65c9-1621876401
branch
from
981f089 to
840c931
Compare
skia-flutter-autoroll
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 26, 2021
skia-flutter-autoroll
deleted the
dart-sdk-flutter-engine-e6493f56-3cbf-4118-bb65-090a1bad65c9-1621876401
branch
richkadel
added a commit
to richkadel/engine
that referenced
this pull request
Jun 24, 2021
As of fuchsia.git commit 413b2189b11faf0be2843859b900853c100beb0c Merged into the current PR, while based on: > commit 2e0b10f > Author: skia-flutter-autoroll <skia-flutter-autoroll@skia.org> > Date: Mon May 24 14:14:02 2021 -0400 > > Roll Dart SDK from c696ecf to bb9d96f (1 revision) (flutter#26370) I also had to: * Update `DEPS` to bring in a recent version of the Fuchsia GN SDK (timestamped within 24 hours of the fuchsia.git sources). * Add the `Handle.replace()` method (which was missing since I am still building with an older version of flutter/engine) * Update build/fuchsia/fidl_gen_cpp.py (from the `flutter/buildroot` repo) to add the `--experimental allow_new_syntax` flag to `fidlc`: ```diff fidlc_command = [ args.fidlc_bin, + '--experimental', + 'allow_new_syntax', '--tables', ``` But I still got some errors with FIDL Dart bindings that I couldn't resolve (below). I may need to update flutter/engine to resolve them: ``` fuchsia-source:///out/fuchsia_release_x64/dartlang/gen/flutter/tools/fuchsia/fidl/fuchsia.intl_package/lib/fidl_async.dart:512:9: Error: Method not found: 'performCtrlWithExceptionHandling'. $fidl.performCtrlWithExceptionHandling(_name, ctrl, () { ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ fuchsia-source:///out/fuchsia_release_x64/dartlang/gen/flutter/tools/fuchsia/fidl/fuchsia.intl_package/lib/fidl_async.dart:518:9: Error: Method not found: 'handleCtrlError'. $fidl.handleCtrlError(ctrl, 'Unexpected message ordinal: ${$message.ordinal}'); ^^^^^^^^^^^^^^^ ```
richkadel
added a commit
to richkadel/engine
that referenced
this pull request
Jun 25, 2021
As of fuchsia.git commit 413b2189b11faf0be2843859b900853c100beb0c Merged into the current PR, while based on: > commit 2e0b10f > Author: skia-flutter-autoroll <skia-flutter-autoroll@skia.org> > Date: Mon May 24 14:14:02 2021 -0400 > > Roll Dart SDK from c696ecf to bb9d96f (1 revision) (flutter#26370) I also had to: * Update `DEPS` to bring in a recent version of the Fuchsia GN SDK (timestamped within 24 hours of the fuchsia.git sources). * Add the `Handle.replace()` method (which was missing since I am still building with an older version of flutter/engine)
richkadel
added a commit
to richkadel/engine
that referenced
this pull request
Jul 7, 2021
As of fuchsia.git commit 413b2189b11faf0be2843859b900853c100beb0c Merged into the current PR, while based on: > commit 2e0b10f > Author: skia-flutter-autoroll <skia-flutter-autoroll@skia.org> > Date: Mon May 24 14:14:02 2021 -0400 > > Roll Dart SDK from c696ecf to bb9d96f (1 revision) (flutter#26370) I also had to: * Update `DEPS` to bring in a recent version of the Fuchsia GN SDK (timestamped within 24 hours of the fuchsia.git sources). * Add the `Handle.replace()` method (which was missing since I am still building with an older version of flutter/engine)
richkadel
added a commit
to richkadel/engine
that referenced
this pull request
Jul 22, 2021
As of fuchsia.git commit 413b2189b11faf0be2843859b900853c100beb0c Merged into the current PR, while based on: > commit 2e0b10f > Author: skia-flutter-autoroll <skia-flutter-autoroll@skia.org> > Date: Mon May 24 14:14:02 2021 -0400 > > Roll Dart SDK from c696ecf to bb9d96f (1 revision) (flutter#26370) I also had to: * Update `DEPS` to bring in a recent version of the Fuchsia GN SDK (timestamped within 24 hours of the fuchsia.git sources). * Add the `Handle.replace()` method (which was missing since I am still building with an older version of flutter/engine)
richkadel
added a commit
to richkadel/engine
that referenced
this pull request
Aug 10, 2021
As of fuchsia.git commit 413b2189b11faf0be2843859b900853c100beb0c Merged into the current PR, while based on: > commit 2e0b10f > Author: skia-flutter-autoroll <skia-flutter-autoroll@skia.org> > Date: Mon May 24 14:14:02 2021 -0400 > > Roll Dart SDK from c696ecf to bb9d96f (1 revision) (flutter#26370) I also had to: * Update `DEPS` to bring in a recent version of the Fuchsia GN SDK (timestamped within 24 hours of the fuchsia.git sources). * Add the `Handle.replace()` method (which was missing since I am still building with an older version of flutter/engine)
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dart.googlesource.com/sdk.git/+log/c696ecf5a8a0..bb9d96ffbafa
2021-05-24 dart-luci-ci-builder@dart-ci.iam.gserviceaccount.com Version 2.14.0-146.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md