This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland: Use dispatchKeyEventPreIme, and handle keys sent to InputConnection.sendKeyEvent on Android #22304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent to InputConnection.sendKeyEvent on Android (flutter#21979)" (flutter#22004)" This reverts commit 3658bd7.
dkwingsmt
approved these changes
Nov 4, 2020
Contributor
dkwingsmt
left a comment
dkwingsmt
left a comment
There was a problem hiding this comment.
RSLGTM. The PR has no change from the last reland and only reattempts in a different context (other code).
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 5, 2020
…nputConnection.sendKeyEvent on Android (flutter/engine#22304)
gspencergoog
added a commit
to gspencergoog/engine
that referenced
this pull request
Nov 5, 2020
…nputConnection.sendKeyEvent on Android (flutter#22304)" This reverts commit 7a8057b because it breaks back button functionality.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 5, 2020
…nputConnection.sendKeyEvent on Android (flutter/engine#22304)
gspencergoog
added a commit
to gspencergoog/engine
that referenced
this pull request
Nov 6, 2020
…ent to InputConnection.sendKeyEvent on Android (flutter#22304)" (flutter#22321)" This reverts commit 5d481fb.
chaselatta
pushed a commit
to chaselatta/engine
that referenced
this pull request
Nov 30, 2020
…ection.sendKeyEvent on Android (flutter#22304) This re-lands flutter#21163, which was reverted in flutter#22004 Now that flutter/flutter#67359 has landed, this change will no longer cause spaces (and other shortcuts) to be ignored in text fields if there is no action associated with the intent, even if there is a shortcut key mapping to an intent. It also no longer causes web test failures (as far as I can tell without submitting it: the same tests don't fail locally). Here's the original PR description: This switches from using dispatchKeyEvent to using dispatchKeyEventPreIme so that keys can be intercepted before they reach the IME and be handled by the framework. It also now intercepts key events sent to InputConnection.sendKeyEvent, as some IMEs do (e.g. the Hacker's Keyboard), and sends the to Flutter before sending them to the IME (which it now only does if they are not handled by the framework). This fixes the problem where pressing TAB on a hardware keyboard sends the tab to both the text field and to the focus traversal system. Note that we still can't intercept all keystrokes given to a soft keyboard, only those which the soft keyboard decides to send to InputConnection.sendKeyEvent.
chaselatta
pushed a commit
to chaselatta/engine
that referenced
this pull request
Nov 30, 2020
…nputConnection.sendKeyEvent on Android (flutter#22304)" (flutter#22321) This reverts commit 7a8057b because it breaks back button functionality.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This re-lands #21163, which was reverted in #22004
Now that flutter/flutter#67359 has landed, this change will no longer cause spaces (and other shortcuts) to be ignored in text fields if there is no action associated with the intent, even if there is a shortcut key mapping to an intent.
It also no longer causes web test failures (as far as I can tell without submitting it: the same tests don't fail locally).
Here's the original PR description:
This switches from using
dispatchKeyEventto usingdispatchKeyEventPreImeso that keys can be intercepted before they reach the IME and be handled by the framework.It also now intercepts key events sent to
InputConnection.sendKeyEvent, as some IMEs do (e.g. the Hacker's Keyboard), and sends the to Flutter before sending them to the IME (which it now only does if they are not handled by the framework).This fixes the problem where pressing TAB on a hardware keyboard sends the tab to both the text field and to the focus traversal system.
Note that we still can't intercept all keystrokes given to a soft keyboard, only those which the soft keyboard decides to send to
InputConnection.sendKeyEvent.Related Issues
Tests
Breaking Change