Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Avoid a copy in EncodeImage (#19504)" #19739

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Revert "Avoid a copy in EncodeImage (#19504)" #19739

merged 1 commit into from
Jul 14, 2020

Conversation

zanderso
Copy link
Member

This reverts commit f9acd08.

Non-genuine TypedData passed to engine.

When the exception was thrown, this was the stack:
#0      _instantiateImageCodec (dart:ui/painting.dart:1760:33)
#1      instantiateImageCodec.<anonymous closure> (dart:ui/painting.dart:1731:12)

@zanderso zanderso requested a review from dnfield July 14, 2020 16:26
@auto-assign auto-assign bot requested a review from GaryQian July 14, 2020 16:26
@zanderso
Copy link
Member Author

'Mac iOS Engine' failure was a known flake. Landing revert on red to unblock rolls.

@zanderso zanderso merged commit 72d0c36 into flutter:master Jul 14, 2020
@zanderso zanderso deleted the revert-external-encode-image branch July 14, 2020 17:29
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 14, 2020
@engine-flutter-autoroll
72d0c36 Revert "Avoid a copy in EncodeImage (flutter#19504)" (flutter…
14616cf 
…/engine#19739)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dnfield dnfield dnfield approved these changes

@GaryQian GaryQian Awaiting requested review from GaryQian

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zanderso @dnfield @googlebot