Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

In tests run dart code on ui(rather than on platform) thread. #17686

Merged
merged 4 commits into from
Apr 13, 2020
Merged

In tests run dart code on ui(rather than on platform) thread. #17686

merged 4 commits into from
Apr 13, 2020

Conversation

aam
Copy link
Member

@aam aam commented Apr 13, 2020

@auto-assign auto-assign bot requested a review from iskakaushik April 13, 2020 21:27
chinmaygarde
chinmaygarde reviewed Apr 13, 2020
View reviewed changes
Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wont this mean you are preparing the isolate on one thread but running it on another thread? If anything, the entirety of RunDartCodeInIsolate should run on the UI isolate.

@aam
Copy link
Member Author

aam commented Apr 13, 2020

Wont this mean you are preparing the isolate on one thread but running it on another thread? If anything, the entirety of RunDartCodeInIsolate should run on the UI isolate.

True, fixed.

@aam aam added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Apr 13, 2020
@fluttergithubbot fluttergithubbot merged commit 053da38 into flutter:master Apr 13, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 14, 2020
@engine-flutter-autoroll
053da38 In tests run dart code on ui(rather than on platform) thread. (…
d66720e 
…flutter/engine#17686)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 14, 2020
@engine-flutter-autoroll
053da38 In tests run dart code on ui(rather than on platform) thread. (…
1682276 
…flutter/engine#17686)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 14, 2020
@engine-flutter-autoroll
053da38 In tests run dart code on ui(rather than on platform) thread. (…
d1362c0 
…flutter/engine#17686)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 14, 2020
@engine-flutter-autoroll
053da38 In tests run dart code on ui(rather than on platform) thread. (…
39ac6bb 
…flutter/engine#17686)
This was referenced Apr 14, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 14, 2020
@engine-flutter-autoroll
053da38 In tests run dart code on ui(rather than on platform) thread. (…
4a208d9 
…flutter/engine#17686)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 14, 2020
@engine-flutter-autoroll
053da38 In tests run dart code on ui(rather than on platform) thread. (…
0712a46 
…flutter/engine#17686)
This was referenced Apr 14, 2020
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 14, 2020
@engine-flutter-autoroll
053da38 In tests run dart code on ui(rather than on platform) thread. (…
587f08d 
…flutter/engine#17686)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 14, 2020
@engine-flutter-autoroll
053da38 In tests run dart code on ui(rather than on platform) thread. (…
20e6593 
…flutter/engine#17686)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 14, 2020
@engine-flutter-autoroll
053da38 In tests run dart code on ui(rather than on platform) thread. (…
ecaf50b 
…flutter/engine#17686)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 14, 2020
@engine-flutter-autoroll
053da38 In tests run dart code on ui(rather than on platform) thread. (…
e10dcae 
…flutter/engine#17686)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 14, 2020
@engine-flutter-autoroll
053da38 In tests run dart code on ui(rather than on platform) thread. (…
f9242e6 
…flutter/engine#17686)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 14, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 15, 2020
@engine-flutter-autoroll
053da38 In tests run dart code on ui(rather than on platform) thread. (…
5d4d2da 
…flutter/engine#17686)
This was referenced Apr 15, 2020
Closed
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 15, 2020
@engine-flutter-autoroll
053da38 In tests run dart code on ui(rather than on platform) thread. (…
5a78e09 
…flutter/engine#17686)
goderbauer pushed a commit to goderbauer/engine that referenced this pull request Apr 16, 2020
@aam @goderbauer
In tests run dart code on ui(rather than on platform) thread. (flutte…
637cb00 
…r#17686)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

@iskakaushik iskakaushik Awaiting requested review from iskakaushik

@rmacnak-google rmacnak-google Awaiting requested review from rmacnak-google

Assignees
No one assigned
Labels
cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MultiFrameImageCodec test fails with multiple mutators error
4 participants
@aam @chinmaygarde @googlebot @fluttergithubbot