This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Felt add integration #17190
Merged
Felt add integration #17190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nturgut
requested review from
ferhatb and
yjbanov
and removed request for
gaaclarke
ferhatb
reviewed
Mar 18, 2020
| } | ||
| } | ||
|
|
||
| print( |
Contributor
There was a problem hiding this comment.
Maybe use Logger class for these with info, warning, error...
Contributor
Author
There was a problem hiding this comment.
I think this is good feedback overall for felt tool. thanks.
yjbanov
reviewed
Mar 18, 2020
yjbanov
reviewed
Mar 19, 2020
Contributor
|
This is pretty close to LGTM. Most of my comments are about style, code health, productivity. Leaving those to your judgement. My remaining real worries are:
|
yjbanov
reviewed
Mar 20, 2020
yjbanov
reviewed
Mar 20, 2020
nturgut
commented
Mar 20, 2020
yjbanov
approved these changes
Mar 20, 2020
added 14 commits
March 20, 2020 17:15
…e readme file partially
added 8 commits
March 20, 2020 17:15
…ed from web_installers repo
nturgut
force-pushed
the
felt_add_integration
branch
from
3afee32 to
4f2abde
Compare
Contributor
Author
|
Merging the PR. I'll check the tests in an hour to see if everything is doing ok. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 24, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 24, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding capability to felt for running integration tests:
Many things are missing, I added to do items for each. For now one can run the integration tests using the instructions on readme.
Fixing Issue: flutter/flutter#52909
I will handle the other issue in a separate PR: flutter/flutter#52983